Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal: add workaround for ppc64le PXE bug #3661

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 20, 2023

@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2023

This still needs to be tested.

@dustymabe
Copy link
Member

I was thinking we would just fix it in build.sh rather than at runtime.

@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2023

Hmm, not sure if that's possible. The fix needs to be done in the tftpdir that grub2-mknetdir creates.

@dustymabe
Copy link
Member

Hmm, not sure if that's possible. The fix needs to be done in the tftpdir that grub2-mknetdir creates.

ahh - ok

@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2023

Yup, confirmed this works!

[coreos-assembler]$ kola testiso pxe* -S
__  Skipping kola test pattern "fcos.internet":
  __ https://github.com/coreos/coreos-assembler/pull/1478
__  Skipping kola test pattern "podman.workflow":
  __ https://github.com/coreos/coreos-assembler/pull/1478
Ignoring verification of signature on metal image
Running test: pxe-online-install.ppcfw
qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM
Falling back to kernel-irqchip=off
qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM
Falling back to kernel-irqchip=off
PASS: pxe-online-install.ppcfw (3m40.174s)
Running test: pxe-offline-install.4k.ppcfw
qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM
Falling back to kernel-irqchip=off
qemu-system-ppc64: warning: kernel_irqchip allowed but unavailable: IRQ_XIVE capability must be present for KVM
Falling back to kernel-irqchip=off
PASS: pxe-offline-install.4k.ppcfw (2m57.177s)

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit 1c722b3 into coreos:main Nov 20, 2023
5 checks passed
jlebon added a commit to jlebon/fedora-coreos-config that referenced this pull request Nov 23, 2023
This reverts commit 077d418.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661
jlebon added a commit to jlebon/os that referenced this pull request Nov 23, 2023
This reverts commit 5e5cbec.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661
jlebon added a commit to jlebon/os that referenced this pull request Nov 23, 2023
This reverts commit 5e5cbec.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
jlebon added a commit to jlebon/fedora-coreos-config that referenced this pull request Nov 23, 2023
This reverts commit 077d418.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this pull request Nov 24, 2023
This reverts commit 077d418.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
jlebon added a commit to jlebon/os that referenced this pull request Dec 4, 2023
This reverts commit 5e5cbec.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
jlebon added a commit to jlebon/os that referenced this pull request Feb 27, 2024
This reverts commit 5e5cbec.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this pull request Mar 18, 2024
This reverts commit 077d418.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
jbtrystram pushed a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
This reverts commit 5e5cbec.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants