Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Revert "denylist: skip PXE tests on ppc64le" #1399

Merged
merged 1 commit into from
Feb 29, 2024
Merged

NO-JIRA: Revert "denylist: skip PXE tests on ppc64le" #1399

merged 1 commit into from
Feb 29, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 23, 2023

This reverts commit 5e5cbec.

Those tests should work now with the workaround added in coreos/coreos-assembler#3661.

@jlebon jlebon mentioned this pull request Nov 23, 2023
Closed
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@HuijingHei
Copy link
Contributor

/retest

gursewak1997
gursewak1997 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@gursewak1997 gursewak1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@mike-nguyen
Copy link
Member

@mrunalp can you override the jira/valid-reference label for this PR? This is a change to which test we run and not any delivered code.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@jlebon
Copy link
Member Author

jlebon commented Dec 4, 2023

Rebased this, but then remembered that ppc64le is totally broken right now in the RHCOS pipeline, so might as well wait for this.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@jlebon
Revert "denylist: skip PXE tests on ppc64le"
09aff27 
This reverts commit 5e5cbec.

Those tests should work now with the workaround added in
coreos/coreos-assembler#3661.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@jlebon jlebon changed the title Revert "denylist: skip PXE tests on ppc64le" NO-JIRA: Revert "denylist: skip PXE tests on ppc64le" Feb 27, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

This reverts commit 5e5cbec.

Those tests should work now with the workaround added in coreos/coreos-assembler#3661.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2024
@jlebon
Copy link
Member Author

jlebon commented Feb 28, 2024

/retest

@HuijingHei
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, gursewak1997, HuijingHei, jlebon, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,aaradhak,gursewak1997,jlebon,marmijo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ede8883 into openshift:master Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gursewak1997 gursewak1997 gursewak1997 approved these changes

@marmijo marmijo marmijo approved these changes

@aaradhak aaradhak aaradhak approved these changes

@cverna cverna Awaiting requested review from cverna

@jschintag jschintag Awaiting requested review from jschintag

Assignees

@gursewak1997 gursewak1997

@HuijingHei HuijingHei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jlebon @HuijingHei @mike-nguyen @openshift-ci-robot @gursewak1997 @marmijo @aaradhak @openshift-merge-robot