Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testiso - iscsi : misc fixes to improve reliability and disable the test for other arches than x86 #3705

Merged
merged 2 commits into from
Jan 31, 2024
Merged

testiso - iscsi : misc fixes to improve reliability and disable the test for other arches than x86 #3705

merged 2 commits into from
Jan 31, 2024

Conversation

jbtrystram
Copy link
Contributor

@jbtrystram jbtrystram commented Jan 23, 2024 •
edited
Loading

  • fix invalid After targets in iscsi services
  • rename target container to targetd : Target is a systemd w
    ord and seems to interfere with systemd, as running
    systemctl stop target shuts the vm down
  • add a wait for the targetd container to be ready before configuring the
    iscsi target. this should be removed when we ship systemd 254 in rhcos
  • Add a healthcheck to the target container and make sure we mark the
    systemd service as started only when targetcli is ready to receive
    commands. Note this is commented out due to an older systemd version in
    rhcos
  • update virtserial channel completion channel name to "testisocompletion"
    to allow the coreos-test-entered-emergency-target.service to write to
    it, as it expects this name.
    This will allow correct failure detection rather than waiting for QEMU
    timeout.
  • add a restart policy on setup-targetcli as it may start too fast so
    we allow it to restart before marking it failed. Disabled for now
    waiting for a systemd update in rhcos

Disable the iscsi test on other arches than x86 : Nested virt does not work through cosa
ref coreos/fedora-coreos-tracker#1657

@jbtrystram jbtrystram changed the title testiso - enable journal forwarding for iscsi test testiso - iscsi : fixups and attempts to make it work on multiarch Jan 23, 2024
@jbtrystram jbtrystram added the help wanted Extra attention is needed label Jan 23, 2024
jlebon
jlebon reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a rebase; the first two commits are already in.

The last two commits could be squashed together.

mantle/cmd/kola/resources/iscsi_butane_setup.yaml Outdated Show resolved Hide resolved
@jbtrystram
Copy link
Contributor Author

console.txt

attached console.txt from aarch64 run of iso-offline-install-iscsi.bios
it was run with this coreos-assembler changes

@jbtrystram jbtrystram mentioned this pull request Jan 24, 2024
Merged
jlebon
jlebon reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up the commits? Needs a rebase and some of the commits squashed.

mantle/cmd/kola/resources/iscsi_butane_setup.yaml Outdated Show resolved Hide resolved
mantle/cmd/kola/resources/iscsi_butane_setup.yaml Show resolved Hide resolved
@jbtrystram jbtrystram force-pushed the iscsi-testiso/enable-journal branch 2 times, most recently from 8164418 to 27a4712 Compare January 30, 2024 09:22
@jbtrystram
Copy link
Contributor Author

@jlebon I rebased the branch, squashed commits with a more detailed commit message and excluded the test from other arches than x86 with a note pointing to coreos/fedora-coreos-tracker#1657

jlebon
jlebon previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but OK as a follow-up too.

mantle/cmd/kola/resources/iscsi_butane_setup.yaml Outdated Show resolved Hide resolved
@jbtrystram
[kola testiso] iscsi - misc fixes to improve reliability
cba8ff6 
- fix invalid After targets in iscsi services
- rename target container to targetd : Target is a systemd w
ord and seems to interfere with systemd, as running
systemctl stop target shuts the vm down
- add a wait for the targetd container to be ready before configuring the
iscsi target. this should be removed when we ship systemd 254 in rhcos
- Add a healthcheck to the target container and make sure we mark the
systemd service as started only when targetcli is ready to receive
commands. Note this is commented out due to an older systemd version in
rhcos
- update virtserial channel completion channel name to "testisocompletion"
to allow the coreos-test-entered-emergency-target.service to write to
it, as it expects this name.
This will allow correct failure detection rather than waiting for QEMU
timeout.
- add a restart policy on setup-targetcli as it may start too fast so
we allow it to restart before marking it failed. Disabled for now
waiting for a systemd update in rhcos
@jbtrystram
Disable the iscsi test on other arches than x86
bd3a6aa 
Nested virt does not work through cosa
ref coreos/fedora-coreos-tracker#1657
@jbtrystram jbtrystram changed the title testiso - iscsi : fixups and attempts to make it work on multiarch testiso - iscsi : misc fixes to improve reliability and disable the test for other arches than x86 Jan 31, 2024
travier
travier approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but LGTM from a quick look.

@jbtrystram jbtrystram enabled auto-merge (rebase) January 31, 2024 09:20
@jbtrystram jbtrystram merged commit 72a85b1 into coreos:main Jan 31, 2024
5 checks passed
@jbtrystram jbtrystram mentioned this pull request Feb 5, 2024
Merged
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Mar 14, 2024
@jbtrystram
denylist: enable iscsi iso-offline-install-iscsi.bios
b87b718 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now
See coreos/coreos-assembler#3705
@jbtrystram jbtrystram mentioned this pull request Mar 14, 2024
Merged
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Mar 14, 2024
@jbtrystram
denylist: enable iscsi iso-offline-install-iscsi.bios
c9a74a9 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now
See coreos/coreos-assembler#3705
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
@jbtrystram
Denylist: enable iscsi test but skip prow
d0ea1a9 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now

However, the iscsi test fails in prow unexpectedly
so skip it here so it can run in the RHCOS jenkins
pipeline at least.
See openshift#1492
See coreos/coreos-assembler#3705
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
@jbtrystram
Denylist: enable iscsi test but skip prow
7ce4044 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now

However, the iscsi test fails in prow unexpectedly
so skip it here so it can run in the RHCOS jenkins
pipeline at least.
See openshift#1492
See coreos/coreos-assembler#3705
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
@jbtrystram
Denylist: enable iscsi test but skip prow
f6db60d 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now

However, the iscsi test fails in prow unexpectedly
so skip it here so it can run in the RHCOS jenkins
pipeline at least.
See openshift#1492
See coreos/coreos-assembler#3705
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
@jbtrystram
Denylist: enable iscsi test but skip prow
d40cef5 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now

However, the iscsi test fails in prow unexpectedly
so skip it here so it can run in the RHCOS jenkins
pipeline at least.
See openshift#1492
See coreos/coreos-assembler#3705
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
@jbtrystram
Denylist: enable iscsi test but skip prow
e8f6fed 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now

However, the iscsi test fails in prow unexpectedly
so skip it here so it can run in the RHCOS jenkins
pipeline at least.
See openshift#1492
See coreos/coreos-assembler#3705
jbtrystram added a commit to jbtrystram/openshift-os that referenced this pull request Apr 22, 2024
@jbtrystram
Denylist: enable iscsi test but skip prow
d12d116 
The multi-arch tests are skipped in kola code and
the x86 test have been working for some time now

However, the iscsi test fails in prow unexpectedly
so skip it here so it can run in the RHCOS jenkins
pipeline at least.
See openshift#1492
See coreos/coreos-assembler#3705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@jlebon jlebon jlebon left review comments

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbtrystram @jlebon @travier