Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kola testiso] iscsi - fix test timeout #3716

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jbtrystram
Copy link
Contributor

#3705 should not have been merged 😬
targetd.sock does not exist, even when running systemctl enable targetd.socket so rely on targetcli to succeed instead.
Tested on x86

Simply rely on `targetcli ls` to succeed to wait for
targetcli to be ready.
@jbtrystram
Copy link
Contributor Author

failing test is unrelated to this change :
[2024-02-05T09:47:55.332Z] --- FAIL: ext.config.networking.ifname-karg.everyboot-systemd-link-file (603.62s)

@travier
Copy link
Member

travier commented Feb 5, 2024

Is targetcli ls failing with a non zero exit code when it's not ready? I can not find this in https://www.mankier.com/8/targetcli.

@travier
Copy link
Member

travier commented Feb 5, 2024

How did this test pass in the PR before? Edit: The test is currently denylisted.

@jbtrystram
Copy link
Contributor Author

Is targetcli ls failing with a non zero exit code when it's not ready? I can not find this in mankier.com/8/targetcli.

I did some additional testing and it seems to work (returning zero when ready) but I can't reproduce a slow run with a debug where it's not ready when called. I get non zero exit codes when trying locally with a crashed targetd so that should work :

$ podman exec -it -l targetcli || echo $?
Could not load module: configfs
255

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I was going off of https://github.com/open-iscsi/targetcli-fb/blob/7d51e94b2bae534e21a3f46a35eed95195ad323d/systemd/targetclid.socket#L6, but possibly systemd acts differently within a container wrt sockets.target?

Anyway, LGTM.

@jbtrystram jbtrystram enabled auto-merge (rebase) February 5, 2024 15:35
@jbtrystram jbtrystram merged commit 3fa46fa into coreos:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants