-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host containerFiles needed for kola tests #3727
Conversation
6f7abb7
to
a6dd6e8
Compare
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Point test that requires containers to use images from the coreos-assembler org. Following coreos#3727 See coreos/fedora-coreos-tracker#1639
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one final comment (let's not wait for CI once that's fixed).
A follow-up to this would be to actually build those images in CI here and run the relevant kola tests using them.
tests/containers/target/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, feels like target
is not descriptive enough, especially given that this directory name becomes the image name. How about targetcli
?
a6dd6e8
to
569b293
Compare
Some kola tests requires additionnal images to work (isci, luks). Until now these images have been maintained by indivudual members of the coreOS team. This moves the images under coreos-assembler for sharing the maintainership, and allowing the images to be periodically rebuilt. See coreos/fedora-coreos-tracker#1639 (comment)
569b293
to
ffec3d1
Compare
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Now that coreos/fedora-coreos-pipeline#959 is merged, we have these images built by the coreOS CI and hosted on the quay.io/coreos-assembler org. Point tests that requires containers to use images from the coreos-assembler org. See coreos#3727 Fixes coreos/fedora-coreos-tracker#1639
Now that coreos/fedora-coreos-pipeline#959 is merged, we have these images built by the coreOS CI and hosted on the quay.io/coreos-assembler org. Point tests that requires containers to use images from the coreos-assembler org. See coreos#3727 Fixes coreos/fedora-coreos-tracker#1639
Now that coreos/fedora-coreos-pipeline#959 is merged, we have these images built by the coreOS CI and hosted on the quay.io/coreos-assembler org. Point tests that requires containers to use images from the coreos-assembler org. See #3727 Fixes coreos/fedora-coreos-tracker#1639
Some kola tests require external images. This job will build and publish the images present under the test/containers path of coreos-assembler. Inital PR for coreos-assembler: coreos/coreos-assembler#3727 x-ref coreos/fedora-coreos-tracker#1639
Some kola tests requires additionnal images to work (isci, luks). Until now these images have been maintained by indivudual members of the coreOS team. This moves the images under coreos-assembler for sharing the maintainership, and allowing the images to be periodically rebuilt.
See coreos/fedora-coreos-tracker#1639 (comment)