Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host containerFiles needed for kola tests #3727

Merged
merged 1 commit into from
Feb 15, 2024
Merged

host containerFiles needed for kola tests #3727

merged 1 commit into from
Feb 15, 2024

Conversation

jbtrystram
Copy link
Contributor

Some kola tests requires additionnal images to work (isci, luks). Until now these images have been maintained by indivudual members of the coreOS team. This moves the images under coreos-assembler for sharing the maintainership, and allowing the images to be periodically rebuilt.

See coreos/fedora-coreos-tracker#1639 (comment)

@jbtrystram jbtrystram mentioned this pull request Feb 13, 2024
Merged
jlebon
jlebon previously approved these changes Feb 13, 2024
View reviewed changes
tests/containers/tang/README.md Outdated Show resolved Hide resolved
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Feb 15, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
3a985b1 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Feb 15, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
148cde7 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Feb 15, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
e08cf8a 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Feb 15, 2024
@jbtrystram
use container images from coreos-assembler org
0c5620f 
Point test that requires containers to use images from the
coreos-assembler org.

Following coreos#3727

See  coreos/fedora-coreos-tracker#1639
@jbtrystram jbtrystram mentioned this pull request Feb 15, 2024
Merged
jlebon
jlebon previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one final comment (let's not wait for CI once that's fixed).

A follow-up to this would be to actually build those images in CI here and run the relevant kola tests using them.

tests/containers/target/README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, feels like target is not descriptive enough, especially given that this directory name becomes the image name. How about targetcli?

@jbtrystram
host containerFiles needed for kola tests
ffec3d1 
Some kola tests requires additionnal images to work (isci, luks). Until
now these images have been maintained by indivudual members of the
coreOS team. This moves the images under coreos-assembler for sharing
the maintainership, and allowing the images to be periodically rebuilt.

See coreos/fedora-coreos-tracker#1639 (comment)
@jlebon jlebon merged commit cc95fc3 into coreos:main Feb 15, 2024
2 of 5 checks passed
@jbtrystram jbtrystram deleted the coreos-owned-test-images branch February 15, 2024 15:01
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Feb 20, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
b343c89 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Mar 5, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
104b4ac 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Mar 19, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
72d6b0a 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Mar 19, 2024
@jbtrystram
Add a new Jenkins job to build containers for kola
46afa1d 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jlebon pushed a commit to jbtrystram/fedora-coreos-pipeline that referenced this pull request Mar 19, 2024
@jbtrystram @jlebon
Add a new Jenkins job to build containers for kola
6d2f2b5 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jlebon pushed a commit to coreos/fedora-coreos-pipeline that referenced this pull request Mar 19, 2024
@jbtrystram @jlebon
Add a new Jenkins job to build containers for kola
686b74d 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Mar 20, 2024
@jbtrystram
tests: use container images from coreos-assembler org
5fde6a0 
Now that coreos/fedora-coreos-pipeline#959
is merged, we have these images built by the coreOS CI and
hosted on the quay.io/coreos-assembler org.

Point tests that requires containers to use images from the
coreos-assembler org.

See  coreos#3727
Fixes coreos/fedora-coreos-tracker#1639
jbtrystram added a commit to jbtrystram/coreos-assembler that referenced this pull request Mar 20, 2024
@jbtrystram
tests: use container images from coreos-assembler org
6f9ae29 
Now that coreos/fedora-coreos-pipeline#959
is merged, we have these images built by the coreOS CI and
hosted on the quay.io/coreos-assembler org.

Point tests that requires containers to use images from the
coreos-assembler org.

See  coreos#3727
Fixes coreos/fedora-coreos-tracker#1639
jlebon pushed a commit that referenced this pull request Mar 20, 2024
@jbtrystram @jlebon
tests: use container images from coreos-assembler org
6cbe502 
Now that coreos/fedora-coreos-pipeline#959
is merged, we have these images built by the coreOS CI and
hosted on the quay.io/coreos-assembler org.

Point tests that requires containers to use images from the
coreos-assembler org.

See  #3727
Fixes coreos/fedora-coreos-tracker#1639
aaradhak pushed a commit to aaradhak/fedora-coreos-pipeline that referenced this pull request May 14, 2024
@jbtrystram @aaradhak
Add a new Jenkins job to build containers for kola
9c7df16 
Some kola tests require external images. This job will build
and publish the images present under the test/containers path
of coreos-assembler.

Inital PR for coreos-assembler: coreos/coreos-assembler#3727

x-ref coreos/fedora-coreos-tracker#1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe left review comments

@travier travier travier left review comments

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbtrystram @dustymabe @jlebon @travier