kola/qemuexec: Add a wwn option for scsis disks #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 5, 2024
Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1] Note that the `wwn` value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it. This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670 [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
jbtrystram
commented
Apr 5, 2024
|
it looks like I messed up something: Edit: Ok, solved. The issue was Wheras with |
jbtrystram
force-pushed
the
kola/wwn-disks
branch
from
2fe9629
to
18f5eff
Compare
jlebon
previously approved these changes
Apr 5, 2024
Add a customizable WWN option for kola DiskSpec to have reliable links under `/dev/disk/by-id/`. With this change kola qemuxec can be run like: `kola qemuexec -D "5G:channel=scsi,wwn=007"` Resulting in the following links: ``` [core@localhost ~]$ rpm -qa sg3_utils sg3_utils-1.48-1.fc40.x86_64 [core@localhost ~]$ ls -l /dev/disk/by-id total 0 lrwxrwxrwx. 1 root root 9 Apr 5 09:05 scsi-30000000000000007 -> ../../sda lrwxrwxrwx. 1 root root 9 Apr 5 09:05 wwn-0x0000000000000007 -> ../../sda ``` This is motivated by recent changes in sg3_utils [1] which removed some udev links. At least one of our tests [2] relying on this started failing. This patch was suggested by @jlebon [3] [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html [2] coreos/fedora-coreos-tracker#1670 [3] coreos/fedora-coreos-tracker#1670 (comment)
jbtrystram
force-pushed
the
kola/wwn-disks
branch
from
18f5eff
to
65dba15
Compare
c4rt0
approved these changes
Apr 9, 2024
jlebon
approved these changes
Apr 10, 2024
|
/retest |
1 similar comment
|
/retest |
jbtrystram
added a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 11, 2024
Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1] Note that the `wwn` value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it. This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670 [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
jbtrystram
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Apr 12, 2024
Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1] Note that the `wwn` value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it. This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670 [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a customizable WWN option for kola DiskSpec to have reliable links under
/dev/disk/by-id/. With this change kola qemuxec can be run like:kola qemuexec -D "5G:channel=scsi,wwn=007"Resulting in the following links:
This is motivated by recent changes in sg3_utils [1] which removed some udev links.
At least one of our tests [2] relying on this started failing. This patch was suggested by @jlebon [3]
[1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
[2] coreos/fedora-coreos-tracker#1670
[3] coreos/fedora-coreos-tracker#1670 (comment)