-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kola/qemuexec: Add a wwn option for scsis disks #3772
Conversation
Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1] Note that the `wwn` value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it. This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670 [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
it looks like I messed up something: Edit: Ok, solved. The issue was
Wheras with
|
2fe9629
to
18f5eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but looks sane overall!
We should also update run.md
.
Add a customizable WWN option for kola DiskSpec to have reliable links under `/dev/disk/by-id/`. With this change kola qemuxec can be run like: `kola qemuexec -D "5G:channel=scsi,wwn=007"` Resulting in the following links: ``` [core@localhost ~]$ rpm -qa sg3_utils sg3_utils-1.48-1.fc40.x86_64 [core@localhost ~]$ ls -l /dev/disk/by-id total 0 lrwxrwxrwx. 1 root root 9 Apr 5 09:05 scsi-30000000000000007 -> ../../sda lrwxrwxrwx. 1 root root 9 Apr 5 09:05 wwn-0x0000000000000007 -> ../../sda ``` This is motivated by recent changes in sg3_utils [1] which removed some udev links. At least one of our tests [2] relying on this started failing. This patch was suggested by @jlebon [3] [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html [2] coreos/fedora-coreos-tracker#1670 [3] coreos/fedora-coreos-tracker#1670 (comment)
18f5eff
to
65dba15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the changes implemented here, and all I can say is that I am saving this PR for future reference. I'm afraid I can't spot anything that looks odd to me.
/lgtm
/retest |
1 similar comment
/retest |
Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1] Note that the `wwn` value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it. This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670 [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1] Note that the `wwn` value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it. This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670 [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
Add a customizable WWN option for kola DiskSpec to have reliable links under
/dev/disk/by-id/
. With this change kola qemuxec can be run like:kola qemuexec -D "5G:channel=scsi,wwn=007"
Resulting in the following links:
This is motivated by recent changes in sg3_utils [1] which removed some udev links.
At least one of our tests [2] relying on this started failing. This patch was suggested by @jlebon [3]
[1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
[2] coreos/fedora-coreos-tracker#1670
[3] coreos/fedora-coreos-tracker#1670 (comment)