Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola/qemuexec: Add a wwn option for scsis disks #3772

Merged
merged 1 commit into from
Apr 11, 2024

Commits on Apr 8, 2024

  1. kola/qemuexec: Add a wwn option for scsis disks

    Add a customizable WWN option for kola DiskSpec to have reliable links
    under `/dev/disk/by-id/`. With this change kola qemuxec can be run like:
    `kola qemuexec -D "5G:channel=scsi,wwn=007"`
    
    Resulting in the following links:
    ```
    [core@localhost ~]$ rpm -qa sg3_utils
    sg3_utils-1.48-1.fc40.x86_64
    [core@localhost ~]$ ls -l /dev/disk/by-id
    total 0
    lrwxrwxrwx. 1 root root  9 Apr  5 09:05 scsi-30000000000000007 -> ../../sda
    lrwxrwxrwx. 1 root root  9 Apr  5 09:05 wwn-0x0000000000000007 -> ../../sda
    ```
    
    This is motivated by recent changes in sg3_utils [1] which
    removed some udev links.
    At least one of our tests [2] relying on this started failing.
    This patch was suggested by @jlebon [3]
    
    [1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
    [2] coreos/fedora-coreos-tracker#1670
    [3] coreos/fedora-coreos-tracker#1670 (comment)
    jbtrystram committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    65dba15 View commit details
    Browse the repository at this point in the history