Skip to content

Commit

Permalink
live-generator: Add Options=ro to our mounts
Browse files Browse the repository at this point in the history
The default is a writable mount, and right now the
kernel emits a warning when the mount succeeds
because the underlying block device is read-only.

Which...actually turns out to *also* be the cause behind
the races we've been seeing mounting the ISO
coreos/fedora-coreos-tracker#523

I believe what's happening is one of the bits of udev
is probing the ISO and doing a read-only mount at the same time we're
trying to mount it.

From the kernel perspective it's fine to have multiple concurrent
read-only mounts, but because ours was requested as writable,
if we happend to be trying to do our mount at the same time
as the probing the kernel will reject it.
  • Loading branch information
cgwalters committed Jun 26, 2020
1 parent 0b6c227 commit 9abc1b4
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ Requires=${isosrc_escaped}
[Mount]
What=/${isosrc}
Where=/run/media/iso
Options=ro
Type=iso9660
EOF

Expand Down

0 comments on commit 9abc1b4

Please sign in to comment.