Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

races in boot.mount #523

Closed
cgwalters opened this issue Jun 5, 2020 · 2 comments · Fixed by coreos/fedora-coreos-config#457
Closed

races in boot.mount #523

cgwalters opened this issue Jun 5, 2020 · 2 comments · Fixed by coreos/fedora-coreos-config#457

Comments

@cgwalters
Copy link
Member

coreos/fedora-coreos-config#346 (comment)

We have multiple things mounting /boot and we're not cleanly waiting for the device. coreos/fedora-coreos-config#420 tried to fix this but was withdrawn; we will need some solution.

cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this issue Jun 5, 2020
I believe this is the core issue; on one failing run I see the
services being interleaved.  Remove the "retry mounting" hack
to prove it.

Closes: coreos/fedora-coreos-tracker#523
cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this issue Jun 8, 2020
I believe this is the core issue; on one failing run I see the
services being interleaved.  Remove the "retry mounting" hack
to prove it.

Closes: coreos/fedora-coreos-tracker#523
jlebon pushed a commit to coreos/fedora-coreos-config that referenced this issue Jun 8, 2020
I believe this is the core issue; on one failing run I see the
services being interleaved.  Remove the "retry mounting" hack
to prove it.

Closes: coreos/fedora-coreos-tracker#523
@dustymabe
Copy link
Member

The fix for this went into testing stream release 32.20200615.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Jun 19, 2020
cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this issue Jun 26, 2020
The default is a writable mount, and right now the
kernel emits a warning when the mount succeeds
because the underlying block device is read-only.

Which...actually turns out to *also* be the cause behind
the races we've been seeing mounting the ISO
coreos/fedora-coreos-tracker#523

I believe what's happening is one of the bits of udev
is probing the ISO and doing a read-only mount at the same time we're
trying to mount it.

From the kernel perspective it's fine to have multiple concurrent
read-only mounts, but because ours was requested as writable,
if we happend to be trying to do our mount at the same time
as the probing the kernel will reject it.
cgwalters added a commit to coreos/fedora-coreos-config that referenced this issue Jun 26, 2020
The default is a writable mount, and right now the
kernel emits a warning when the mount succeeds
because the underlying block device is read-only.

Which...actually turns out to *also* be the cause behind
the races we've been seeing mounting the ISO
coreos/fedora-coreos-tracker#523

I believe what's happening is one of the bits of udev
is probing the ISO and doing a read-only mount at the same time we're
trying to mount it.

From the kernel perspective it's fine to have multiple concurrent
read-only mounts, but because ours was requested as writable,
if we happend to be trying to do our mount at the same time
as the probing the kernel will reject it.
@dustymabe
Copy link
Member

The fix for this went into stable stream release 32.20200615.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants