live-generator: Add Options=ro to our mounts #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is a writable mount, and right now the kernel emits a warning when the mount succeeds because the underlying block device is read-only. Which...actually turns out to *also* be the cause behind the races we've been seeing mounting the ISO coreos/fedora-coreos-tracker#523 I believe what's happening is one of the bits of udev is probing the ISO and doing a read-only mount at the same time we're trying to mount it. From the kernel perspective it's fine to have multiple concurrent read-only mounts, but because ours was requested as writable, if we happend to be trying to do our mount at the same time as the probing the kernel will reject it.
|
I don't know why this is seemingly OK in FCOS...I think there might be some other udev rules in RHCOS, or something else in the way boot ordering is happening. But I am 10/10 RHCOS ISO boots with this. |
Closed
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
faq: supporting NM keyfiles and ifcfg files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is a writable mount, and right now the
kernel emits a warning when the mount succeeds
because the underlying block device is read-only.
Which...actually turns out to also be the cause behind
the races we've been seeing mounting the ISO
#437
I believe what's happening is one of the bits of udev
is probing the ISO and doing a read-only mount at the same time we're
trying to mount it.
From the kernel perspective it's fine to have multiple concurrent
read-only mounts, but because ours was requested as writable,
if we happend to be trying to do our mount at the same time
as the probing the kernel will reject it.