Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-generator: Add Options=ro to our mounts #501

Merged
merged 1 commit into from
Jun 26, 2020

Commits on Jun 26, 2020

  1. live-generator: Add Options=ro to our mounts

    The default is a writable mount, and right now the
    kernel emits a warning when the mount succeeds
    because the underlying block device is read-only.
    
    Which...actually turns out to *also* be the cause behind
    the races we've been seeing mounting the ISO
    coreos/fedora-coreos-tracker#523
    
    I believe what's happening is one of the bits of udev
    is probing the ISO and doing a read-only mount at the same time we're
    trying to mount it.
    
    From the kernel perspective it's fine to have multiple concurrent
    read-only mounts, but because ours was requested as writable,
    if we happend to be trying to do our mount at the same time
    as the probing the kernel will reject it.
    cgwalters committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    8b186a5 View commit details
    Browse the repository at this point in the history