Tweak versioning and set up Zincati & pinger enablement #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In coreos/fedora-coreos-tracker#81, we agreed on a versioning scheme for releases. This patch changes `automatic-version-prefix` to respect this. Note that it's not a perfect fit, since e.g. the first build doesn't have a `.0` prefix. In actuality, versioning in the pipeline will be driven by an external process, and thus the scheme embedded here will have no effect (unless we decide to use rpm-ostree itself as part of the external process... though it'll need some tweaking first). So really, this is more for the benefit of local developers so that versioning looks similar to release builds.
We want to be able to distinguish between release and non-release builds. To do this, we embed a `.dev` marker in the version string so that the default developer workflow will use this. As mentioned in the previous commit message, this will be overridden for release streams. See coreos/fedora-coreos-tracker#212 for more information about this.
On non-release/local developer builds, we don't want Zincati or pinger to be active by default. Key off of the OSTree version and add a config dropin to do this. See discussions about this in: coreos/fedora-coreos-tracker#212
By default, we don't enable Zincati and pinger on testing-devel. See discussions in: coreos/fedora-coreos-tracker#163
bgilbert
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.