Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile: add step for building release metadata #89

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

arithx
Copy link
Contributor

@arithx arithx commented Jul 10, 2019

Adds a step which downloads the fedora-coreos-releng-automation repo
and runs the coreos-meta-translator against the current build to
produce release.json files.

@arithx
Copy link
Contributor Author

arithx commented Jul 10, 2019

Untested (looking into adding a plume command in cosa and wrapping that in a job to do both at once)

Jenkinsfile Outdated Show resolved Hide resolved
@jlebon
Copy link
Member

jlebon commented Jul 11, 2019

Untested (looking into adding a plume command in cosa and wrapping that in a job to do both at once)

You mean the new cosa command would run coreos-meta-translator?

Did you mean to hold this until it's part of cosa, or getting this in provisionally? I'd vote for the latter.

@arithx
Copy link
Contributor Author

arithx commented Jul 11, 2019

You mean the new cosa command would run coreos-meta-translator?

No adding the building of plume in the cosa container as well as a wrapper for it.

I was planning on adding that piece (and spinning a PR to use the new plume cosa command in the fedora-coreos-pipeline so I could test both this PR as well as the one for plume at the same time).

For this I'm fine with having it outside of cosa for now.

@jlebon
Copy link
Member

jlebon commented Jul 11, 2019

OK gotcha. Let's hold it for now then.

@jlebon jlebon added the hold Waiting for something label Jul 11, 2019
Adds a step which downloads the `fedora-coreos-releng-automation` repo
and runs the `coreos-meta-translator` against the current build to
produce `release.json` files.
@arithx
Copy link
Contributor Author

arithx commented Jul 11, 2019

Blocked by coreos/coreos-assembler#580 (the meta translator dies with the current cosa builds.json layout)

@jlebon
Copy link
Member

jlebon commented Jul 11, 2019

coreos/coreos-assembler#580 has merged, but our bucket layout is still on the old one. Chatted with @bgilbert and once coreos/fedora-coreos-config#112 is merged which has the new versioning scheme, we'll just aws s3 mv s3://...builds.json{,.old} instead of migrating the old builds. We will later delete these builds.

IOW, this is now soft blocked on coreos/fedora-coreos-config#112.

If you're targeting a new bucket though, now that coreos/coreos-assembler#580 is merged, you should be able to use the new layout in a developer pipeline (once quay finishes rebuilding the container).

@jlebon
Copy link
Member

jlebon commented Jul 12, 2019

OK coreos/fedora-coreos-config#112 is merged now. I completed the move for bodhi-updates. Triggered a new build to sanity check the layout works as expected before switching testing-devel and testing over as well.

@arithx
Copy link
Contributor Author

arithx commented Jul 12, 2019

This works for me in the local cluster.

@jlebon
Copy link
Member

jlebon commented Jul 12, 2019

OK, new layout working fine, though I'm still working on adapting the build browser. I'd like to merge this to test it on bodhi-updates, but it'll fail on testing-devel until we do the move there too (but I'd like to finish adapting the browser first). Hacky, but for the short-term, can you add a || true for now? We'll revert it later.

…lator

Some branches have not moved their branch layout from the old style
which will always fail the meta translator. It was asked
[here](coreos#89 (comment))
to temporarily always pass this stage while transitioning the rest of
the buckets.
@arithx
Copy link
Contributor Author

arithx commented Jul 12, 2019

@jlebon added a HACK commit referencing this comment with the || true for ease of revert later.

@jlebon
Copy link
Member

jlebon commented Jul 12, 2019

Awesome, thanks!

@jlebon jlebon merged commit 7eb0490 into coreos:master Jul 12, 2019
@jlebon jlebon removed the hold Waiting for something label Jul 12, 2019
@jlebon
Copy link
Member

jlebon commented Jul 12, 2019

OK, browser support added, and testing and testing-devel moved over to new layout.
Reverting the || true in #96.

@arithx arithx deleted the meta_trans branch July 12, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants