overlay.d: create new 30gcp-udev-rules overlay #2350
Conversation
We previously had the 65-gce-disk-naming.rules under the 05core overlay. This commit makes a new overlay.d entry specifically for the GCP rules, in this way we can track it and have a better maintenance Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit 9da4327)
- This PR injects/updates the udev rules from google-guest-config package into our overlay (GoogleCloudPlatform/guest-configs@18fbc05). - It works as an workaround for the BZ #2176212. The longer term solution is to add these packages as part of the Fedora/RHEL itself, so we won't need to maintain it, as we can entirely drop it. For this matter the BZ https://bugzilla.redhat.com/show_bug.cgi?id=2182865 was opened requesting a subpackage of google-compute-engine-guest-configs containing only what is needed. For more info: https://bugzilla.redhat.com/show_bug.cgi?id=2176212 https://github.com/GoogleCloudPlatform/guest-configs/tree/master/src/lib/udev Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit b944dd4)
|
I've just realized that this PR and the parent PR does not change the list of overlays in the manifest and is thus not taken into account. |
- Add the new 30gcp-udev-rules overlay into the manifest Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
|
Could we have at least a manual test that this works? A basic automated test would be great. |
The manually check done was to validate if the udev files exist and if the symlinks created were different from before for the nvme disk using a GCP confidencial /non confidencial VM |
|
@travier Since people is waiting for this PR I think make sense for us go head and merge it without the test, since we already validate it manually. I will also cherry-pick the missing part of the manifest to 4.13 |
Agree. Let's get this in. @ravanelli can you work on coreos/fedora-coreos-tracker#1457 soon? |
- Add 30gcp-udev-rules from FCOS - See coreos/fedora-coreos-config#2350 for more info. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Add 30gcp-udev-rules from FCOS - See coreos/fedora-coreos-config#2350 for more info. Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
- Add 30gcp-udev-rules from FCOS - See coreos/fedora-coreos-config#2350 for more info. Signed-off-by: Renata Ravanelli <rravanel@redhat.com> (cherry picked from commit 86c853b)
This is a cherry-pick from #2336, where I merged first in 413 by mistake