Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay.d: Add 30gcp-udev-rules overlay from FCOS #1267

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

ravanelli
Copy link
Member

 - Add 30gcp-udev-rules from FCOS
 - See coreos/fedora-coreos-config#2350 for more
   info.

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@travier
Copy link
Member

travier commented Apr 18, 2023

LGTM but as we have no test for this, it's hard to now if it works. I've suggested in coreos/fedora-coreos-tracker#1457 (comment) that we should do the testing in two parts to make sure that we at least have the rules in the initrd before we merge this.

@HuijingHei
Copy link
Contributor

Build with the patch locally and check the result is expected.

[core@cosa-devsh ~]$ ls -l /usr/lib/udev/rules.d/*gce*
-rw-r--r--. 2 root root 1077 Jan  1  1970 /usr/lib/udev/rules.d/64-gce-disk-removal.rules
-rw-r--r--. 2 root root 2000 Jan  1  1970 /usr/lib/udev/rules.d/65-gce-disk-naming.rules
[core@cosa-devsh ~]$ ls -l /usr/lib/udev/google_nvme_id
-rw-r--r--. 2 root root 9186 Jan  1  1970 /usr/lib/udev/google_nvme_id

@HuijingHei
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,ravanelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4130f6a and 2 for PR HEAD 86c853b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2023

@ravanelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 06ad7ec into openshift:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants