Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-11791: Bump fedora-coreos-config #1259

Merged
merged 1 commit into from
May 2, 2023

Conversation

ravanelli
Copy link
Member

@ravanelli ravanelli commented Apr 14, 2023

    Renata Ravanelli (2):
          overlay.d: Add 30gcp-udev-rules dracut module
          kola: Add files to be verified in initrd test

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 14, 2023
@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-11791, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13.z" instead
  • expected dependent Jira Issue OCPBUGS-11790 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-11799 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-11799 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11791: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11791: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-11791, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11790 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-11799 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-11799 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Renata Ravanelli (1):
     overlay.d: Add 30gcp-udev-rules dracut module
``

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11791: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-11791, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11790 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-11799 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-11799 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Renata Ravanelli (1):
     overlay.d: Add 30gcp-udev-rules dracut module

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravanelli
Copy link
Member Author

/retest

@travier
Copy link
Member

travier commented Apr 18, 2023

/label backport-risk-assessed
/label cherry-pick-approved

We'll either need a valid bug label override for this one or we'll need to have it land in an RHCOS boot image bump to satisfy the bot.

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 18, 2023
@travier
Copy link
Member

travier commented Apr 18, 2023

Hum, what's pulling this overlay in RHCOS? I don't see that in this commit not in the repo so far. Am I missing something?

@jlebon
Copy link
Member

jlebon commented Apr 18, 2023

Hum, what's pulling this overlay in RHCOS? I don't see that in this commit not in the repo so far. Am I missing something?

I think you're right. It seems like we're missing a symlink in overlay.d/ to the overlay in the FCOS submodule (and adding it to the manifest).

An example overlay doing something similar to what we want here is 25azure-udev-rules. Maybe let's fix that in master and then backport it as part of this PR?

@ravanelli
Copy link
Member Author

Hum, what's pulling this overlay in RHCOS? I don't see that in this commit not in the repo so far. Am I missing something?

New PR for it: #1267

@ravanelli
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-11791, which is invalid:

  • expected dependent Jira Issue OCPBUGS-11790 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
  • expected dependent Jira Issue OCPBUGS-11799 to target a version in 4.14.0, but it targets "4.13.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Apr 18, 2023

/hold
Pending backport of #1267 and testing.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023
```
Renata Ravanelli (2):
      overlay.d: Add 30gcp-udev-rules dracut module
      kola: Add files to be verified in initrd test
```

Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

@ravanelli: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-11791: Bump fedora-coreos-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@ravanelli: This pull request references Jira Issue OCPBUGS-11791, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

   Renata Ravanelli (2):
         overlay.d: Add 30gcp-udev-rules dracut module
         kola: Add files to be verified in initrd test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravanelli
Copy link
Member Author

/hold Pending backport of #1267 and testing.

Backport: #1272
Tests: Update the bump to include it

@sdodson sdodson removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 1, 2023
@sdodson sdodson added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 1, 2023
@mike-nguyen
Copy link
Member

/lgtm

@ravanelli
Copy link
Member Author

/override ci/prow/scos-9-build-test-qemu

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mike-nguyen, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mike-nguyen,ravanelli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

@ravanelli: Overrode contexts on behalf of ravanelli: ci/prow/scos-9-build-test-qemu

In response to this:

/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

@ravanelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ravanelli
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
@ravanelli
Copy link
Member Author

/label bugzilla/valid-bug

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

@ravanelli: Can not set label bugzilla/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to this:

/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit ef29beb into openshift:release-4.13 May 2, 2023
@openshift-ci-robot
Copy link

@ravanelli: Jira Issue OCPBUGS-11791: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11791 has not been moved to the MODIFIED state.

In response to this:

   Renata Ravanelli (2):
         overlay.d: Add 30gcp-udev-rules dracut module
         kola: Add files to be verified in initrd test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants