Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Don't include Wi-Fi firmwares starting with Fedora 41 #2980

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

travier
Copy link
Member

@travier travier commented Apr 23, 2024

manifests: Don't include Wi-Fi firmwares starting with Fedora 41

Move Wi-Fi firmwares to their own manifest so that we can automatically
drop then when we rebase to Fedora 41.

We can safely do that now that we have included a warning for existing
users.

See: #2978
Fixes: coreos/fedora-coreos-tracker#1575

@travier travier changed the title manifests: Move wifi firmware their own manifest manifests: Move wifi firmwares to their own manifest Apr 23, 2024
@travier travier force-pushed the testing-devel-wifi-firmware branch from b38a1e2 to fac05d8 Compare April 23, 2024 10:08
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself LGTM though shouldn't the commit title be e.g.

manifests: don't ship Wi-Fi firmwares on f41+

?

Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Timothée ! I indeed forgot that bit on the other PR !

@travier
Copy link
Member Author

travier commented Apr 23, 2024

manifests: don't ship Wi-Fi firmwares on f41+

Indeed, agree. Do you think it's worth pushing an update?

@travier
Copy link
Member Author

travier commented Apr 23, 2024

I'll do it. We are not in a hurry

@travier travier changed the title manifests: Move wifi firmwares to their own manifest manifests: Don't include Wi-Fi firmwares starting with Fedora 41 Apr 23, 2024
Move Wi-Fi firmwares to their own manifest so that we can automatically
drop then when we rebase to Fedora 41.

We can safely do that now that we have included a warning for existing
users.

See: coreos#2978
Fixes: coreos/fedora-coreos-tracker#1575
@travier travier force-pushed the testing-devel-wifi-firmware branch from fac05d8 to 32a3f96 Compare April 23, 2024 15:52
@travier travier merged commit e6749f6 into coreos:testing-devel Apr 23, 2024
3 checks passed
@travier travier deleted the testing-devel-wifi-firmware branch April 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropping some firmware packages that provide Wi-Fi firmware
3 participants