dropping some firmware packages that provide Wi-Fi firmware

[dustymabe]

The linux-firmware package dropped the following firmware subpackages as requirements in F39+:

    atheros-firmware-20230804-153.fc38.noarch
    brcmfmac-firmware-20230804-153.fc38.noarch
    mt7xxx-firmware-20230804-153.fc38.noarch
    realtek-firmware-20230804-153.fc38.noarch 

We should determine if this is a change we want to make.

[travier]

We don't ship any wifi support and generally redirect to Fedora IoT or layering for those use cases, so it's a +1 for me.

Should we discuss this in a meeting?

[dustymabe]

We don't ship any wifi support and generally redirect to Fedora IoT or layering for those use cases, so it's a +1 for me.

I think my biggest concern here is functionality changing without warning. One example: I layer in NetworkManager-wifi on a system I have. IIUC if we transparently pick up this change then the wifi in my system will stop working because NetworkManager-wifi doesn't name those firmware packages as requirements.

I think the state is fine for new installs, but for existing systems some care should be taken.

Should we discuss this in a meeting?

Yes! Added the meeting label. I created this ticket so we could discuss it in a meeting and also revert the drop in next for now while we figure out what we want to do.

[travier]

I think my biggest concern here is functionality changing without warning. One example: I layer in NetworkManager-wifi on a system I have. IIUC if we transparently pick up this change then the wifi in my system will stop working because NetworkManager-wifi doesn't name those firmware packages as requirements.

Good point. Then we should probably announce it. I don't think we should keep them in but that can be discussed during the meeting.

[travier]

From today's meeting:

  * AGREED: We’ll keep the firmware in the upcoming next releases. We’ll
    revisit this discussion next week (travier, 17:38:44)

[dustymabe]

Capturing some of the discussion from the meeting I think we discussed a few options:

1. having NetworkManager-wifi require the wifi firmware packages in the future:
   • involves another team, not great because it requires firmwares that aren't needed
2. running a migration that detects if NetworkManager-wifi is layered and add the 4 firmware packages to the layering requests
3. adding a CLHM helper that detects when NetworkManager-wifi is layered and warning/instructing the user on necessary action.

In the meeting we were leaning more towards the last option and making the "warning period" last until F40 is released, but as mentioned in the previous comment we'll discuss more and finalize the plan next week.

[travier]

The issue with options 2 & 3 is that it extends the lifetime of the CLHM unit warning for modules to a full release worth of time: coreos/fedora-coreos-config#2510. While the module related CLHM was limited in time until the F39 release, this one will be there for a while.

[dustymabe]

The issue with options 2 & 3 is that it extends the lifetime of the CLHM unit warning for modules to a full release worth of time: coreos/fedora-coreos-config#2510. While the module related CLHM was limited in time until the F39 release, this one will be there for a while.

Not sure I completely understand. IIUC this CLHM helper would have nothing to do with coreos/fedora-coreos-config#2510 (i.e. this has nothing to do with modularity). It would be implemented similarly, but be independent code. The CLHM helper added in coreos/fedora-coreos-config#2510 will essentially be dead code in a month's time because releasever == 38 will no longer be true.

[travier]

Turns out rpm-ostree is called by Zincati on boot anyway so the CLHM is not adding much overhead, thus resolving my concerns.

[travier]

From today's meeting:

  * AGREED: We'll keep the packages in FCOS until the rebase to F40.
    We'll add a CLHM module to warn for systems where wifi packages are
    layered and we'll send a warning mail.  (travier, 17:03:46)

[dustymabe]

Since we didn't follow through on the CLHM helper and the email warning to users I'm guessing we need to modify this proposal to target F41 instead.

[travier]

I think we should still do it, warning or not. WiFi is not part of the default image so we should not go out of our way to make it work.

[travier]

From #1700 (comment), we'll need to add

nxpwireless-firmware
tiwilink-firmware

back as well to keep parity with current F39 content.

[travier]

Ideally we would document how to setup WiFi on Fedora CoreOS and document all the caveats around firmwares and layering.

[dustymabe]

Let's keep this open for when this ships in our prod streams.

[c4rt0]

I have no idea how I closed this issue as complete - sorry folks, it must've been an unexpected 'Enter' stroke.

[travier]

It's because you pushed the commit where I mentioned it as fixed in a branch with a matching name. It should be fine now.