WIP: add AWS EBS NVMe udev rules #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Jun 16, 2020
| fi | ||
| } | ||
|
|
||
| while getopts "hd:n:" o; do |
There was a problem hiding this comment.
These options are pretty cryptic. Can we use long opts instead?
|
In coreos/fedora-coreos-tracker#104 (comment) we had a suggestion from the community to maybe try to get these udev rules into systemd. So I started a discussion upstream about that. Upstream systemd seems willing to accept rules on a case by case basis. Should we try to see if they'll accept rules upstream first? |
The script is from Container Linux: coreos/fedora-coreos-tracker#104 (comment), I changed it and tested to make sure it works on fcos.
velothump
reviewed
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the udev rules for AWS EBS NVMe.