manifests: Addition of nvme-cli #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Aug 14, 2020
manifests/fedora-coreos-base.yaml
Outdated
| @@ -157,6 +157,8 @@ packages: | |||
| - kbd | |||
| # Parsing/Interacting with JSON data | |||
| - jq | |||
| # nvme-cli for udev rules | |||
There was a problem hiding this comment.
Since we're adding it independent of the udev rules let's just make the comment more generic. Something like:
Suggested change
| # nvme-cli for udev rules | |
| # nvme-cli for managing nvme disks |
There was a problem hiding this comment.
Sure, Thank you for the review @dustymabe .
c4rt0
pushed a commit
to c4rt0/fedora-coreos-config
that referenced
this pull request
Mar 27, 2023
docs/faq: update multipath instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds
nvme-clito provide an interface that allows host software utilities to communicate with nvme disks.The missing
nvmebinary was brought up over in a tracker issue [1] and also discussed during the 08/12 meeting [2] where there was agreement that we should include this utility in the host.[1] coreos/fedora-coreos-tracker#601
[2] https://lists.fedoraproject.org/archives/list/coreos@lists.fedoraproject.org/message/5E66QVX7F6HRZXMY4GEWQW6SU3GUOQ3G/