Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for kubevirt container image pushing #860

Merged
merged 5 commits into from
May 3, 2023

Commits on May 1, 2023

  1. jobs/release: drop --arch args for cosa push-container-manifest

    If not specified the code will default to all built arches. We need
    this because we'll be adding kubevirt soon and it will only be built
    for x86_64.
    
    See also coreos/coreos-assembler#3436
    dustymabe committed May 1, 2023
    Configuration menu
    Copy the full SHA
    516c654 View commit details
    Browse the repository at this point in the history
  2. add registry_repo config for kubevirt (containerdisk)

    For Fedora CoreOS we'll ship to quay.io/fedora/fedora-coreos-kubevirt.
    See coreos/fedora-coreos-tracker#1126 (comment)
    dustymabe committed May 1, 2023
    Configuration menu
    Copy the full SHA
    cc341c5 View commit details
    Browse the repository at this point in the history
  3. libcloud: drop code to upload Kubevirt

    This is going to be handled by the container pushing code in the release
    job so we don't need it here.
    
    The buildextend-kubevirt --upload pieces were also removed in
    coreos/coreos-assembler@a4cf183
    so it doesn't work anyway.
    dustymabe committed May 1, 2023
    Configuration menu
    Copy the full SHA
    1ed32eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1a85e0 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. config: add container image tags to push to and drop add_build_tags

    This commit updates the config to be able to specify which tags to
    push to inside the registry_repos definition. For example, we went
    from:
    
      oscontainer: quay.io/fedora/fedora-coreos
    
    to:
    
      oscontainer:
        repo: quay.io/fedora/fedora-coreos
        tags: ["${STREAM}"]
    
    This allows us to do things like embed any needed "tag_suffix" in
    the config rather than in the code. i.e. downstream now our extensions
    container entry will look like:
    
      extensions:
        repo: quay.io/openshift-release-dev/ocp-v4.0-art-dev
        tags: ["${STREAM}-extensions", "${VERSION}-extensions"]
    
    It also means we can now get rid of the `add_build_tag` hack that
    we had in the past.
    dustymabe committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ae8918b View commit details
    Browse the repository at this point in the history