Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FCOS stream metadata sample/rationale/release #1213

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

aaradhak
Copy link
Member

@aaradhak aaradhak commented May 31, 2022

To have a complete representation of the artifacts we support in the
stream metadata sample,rationale & release, the FCOS stream metadata sample/
rationale/release have been updated with the missing platforms.

Resolves : https://issues.redhat.com/browse/COS-1364

@aaradhak aaradhak requested a review from bgilbert May 31, 2022 19:57
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right general idea overall; just needs a few fixes. Thanks for handling this.

metadata/stream/rationale.yaml Outdated Show resolved Hide resolved
metadata/stream/rationale.yaml Outdated Show resolved Hide resolved
metadata/release/sample.json Show resolved Hide resolved
metadata/stream/rationale.yaml Show resolved Hide resolved
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally. A few small problems to fix, including a couple of bugs in the original files.

metadata/stream/rationale.yaml Show resolved Hide resolved
metadata/release/sample.json Outdated Show resolved Hide resolved
metadata/release/sample.json Show resolved Hide resolved
metadata/release/sample.json Show resolved Hide resolved
metadata/release/sample.json Show resolved Hide resolved
metadata/stream/rationale.yaml Outdated Show resolved Hide resolved
@aaradhak aaradhak changed the title Updated FCOS stream metadata sample/rationale Updated FCOS stream metadata sample/rationale/release Jun 3, 2022
@miabbott
Copy link
Member

In metadata/stream/rationale.yaml, let's make sure all the entries for location and signature are unique for consistency.

For example:

location: https://artifacts.example.com/aeng0xah6vaaVosh.qcow2.xz
signature: https://artifacts.example.com/aeng0xah6vaaVosh.qcow2.xz.sig

...occurs 6 times in that file

@aaradhak
Copy link
Member Author

In metadata/stream/rationale.yaml, let's make sure all the entries for location and signature are unique for consistency.

For example:

location: https://artifacts.example.com/aeng0xah6vaaVosh.qcow2.xz
signature: https://artifacts.example.com/aeng0xah6vaaVosh.qcow2.xz.sig

...occurs 6 times in that file

have changed all location and signature entries to be unique.

@aaradhak aaradhak closed this Jun 10, 2022
@aaradhak aaradhak reopened this Jun 10, 2022
metadata/release/sample.json Outdated Show resolved Hide resolved
metadata/release/sample.json Outdated Show resolved Hide resolved
metadata/stream/rationale.yaml Outdated Show resolved Hide resolved
metadata/stream/rationale.yaml Outdated Show resolved Hide resolved
metadata/stream/sample.json Outdated Show resolved Hide resolved
metadata/release/sample.json Outdated Show resolved Hide resolved
metadata/stream/rationale.yaml Outdated Show resolved Hide resolved
@aaradhak aaradhak force-pushed the arstreammetadata branch 2 times, most recently from 6d89458 to 279d016 Compare June 15, 2022 19:47
To have a complete representation of the artifacts we support in the
stream metadata sample, rationale & release, the FCOS stream metadata
sample/rationale/release have been updated with the missing platforms.

Resolves https://issues.redhat.com/browse/COS-1364
@aaradhak aaradhak merged commit fde4015 into coreos:main Jun 16, 2022
@bgilbert bgilbert mentioned this pull request Feb 15, 2023
29 tasks
@baude baude mentioned this pull request Feb 17, 2023
26 tasks
@jbtrystram jbtrystram mentioned this pull request Nov 8, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants