This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl TLS for fleet API #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #984 |
| globalFlagset.StringVar(&globalFlags.EtcdCertFile, "etcd-certfile", "", "etcd cert file authentication") | ||
| globalFlagset.StringVar(&globalFlags.EtcdCAFile, "etcd-cafile", "", "etcd CA file authentication") | ||
|
|
||
| globalFlagset.StringVar(&globalFlags.KeyFile, "keyfile", "", "Location of TLS key file") |
There was a problem hiding this comment.
Could you explain a little more explicitly this is for the fleet HTTP API, so there's even less chance of people getting confused with etcd?
There was a problem hiding this comment.
It's used for both the etcd and the fleet API. Are you the one that is confused?
There was a problem hiding this comment.
You know I don't speak spanish.
|
sure pal, 🚢 |
bcwaldon
force-pushed
the
fleetctl-tls
branch
from
f9c8da3
to
89e5e02
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.