Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Support base and user configs #32

Closed
bgilbert opened this issue Dec 14, 2018 · 5 comments
Closed

Support base and user configs #32

bgilbert opened this issue Dec 14, 2018 · 5 comments
Labels
jira for syncing to jira

Comments

@bgilbert
Copy link
Contributor

We will need to support:

In CL these are handled by ignition-setup.service, which is currently disabled here because the original version relies on the OEM partition.

@bgilbert
Copy link
Contributor Author

Unlike Container Linux, in which platform agents are kept in a separate partition outside the base OS image, Fedora CoreOS will include platform agents directly in the base image. So, in general, it doesn't make as much sense to enable agents using Ignition. Instead, the service units can also be shipped in the base image and conditionalized with a ConditionKernelCommandLine or similar.

GCE OS Login enablement may be an exception, since we have to override config files in /etc but give the user the option of overriding them back.

@bgilbert bgilbert added this to Proposed in Fedora CoreOS preview via automation Jan 22, 2019
@bgilbert bgilbert moved this from Proposed to Selected in Fedora CoreOS preview Jan 22, 2019
@yrobla
Copy link

yrobla commented Jan 30, 2019

I think that being able to ship user-supplied config.ign is something needed. For the baremetal use case is specially useful, as there are no other ways to parameterize. In case of PXE boot, people could add kernel parameters with the coreos.config_url and it will work. But in case of using virtual media, modifying kernel parameters is not an option, so having the ability to embed some config.ign in the image for modifications like inject ssh key, start some services, etc... is very useful.

@cgwalters
Copy link
Member

User-supplied config.ign, perhaps in the /boot partition.

👍 - seems simple to implement and solves the problem.

@dustymabe
Copy link
Member

@yrobla would you like to try to implement this and open a PR?

@yrobla
Copy link

yrobla commented Feb 2, 2019

Sure, happy to work on that!

dustymabe added a commit to dustymabe/ignition-dracut that referenced this issue Feb 8, 2019
Fedora CoreOS preview automation moved this from Selected to Done Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira for syncing to jira
Projects
No open projects
Development

No branches or pull requests

4 participants