Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpriv/kargs: Copy libostree patch to support KEYWORD kargs #1796

Closed
wants to merge 6 commits into from

Commits on Mar 21, 2019

  1. libpriv/kargs: Copy libostree patch to support KEYWORD kargs

    This is essentially a copy of
    ostreedev/ostree#1785 to our private copy of the
    kargs API. Should really dedupe those...
    
    The really confusing part though was that that patch was intended to fix
    the `rpm-ostree kargs --append EMPTYKEY=` case (coreos#1706), yet the
    `rpmostree kargs --append KEYWORD` case (coreos#1779) wasn't also fixed, even
    though that same ostree patch clearly fixes and tests for that too.
    
    To make a long story short, we were passing buggy kargs to ostree, which
    before that patch, had itself buggy kargs parsing which conveniently
    fixed back the kargs we passed for the `KEYWORD` case.
    
    Closes: coreos#1779
    jlebon committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    fb877a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. build: Bump minimum glib2 version to 2.56

    That's the latest available in (f28, el8). Prep for using some new APIs
    without tripping compiler warnings.
    jlebon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    8b72510 View commit details
    Browse the repository at this point in the history
  2. libpriv/kargs: Use const char* for delete API

    We don't need to modify the key we're passed, so just use `const`.
    jlebon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    a11435f View commit details
    Browse the repository at this point in the history
  3. tests/test-kargs: Check for no error first

    When we expect a test to not fail, let's `g_assert_no_error` first so
    that if it fails, we get an exact printout of what error we encountered
    when we expected none.
    jlebon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    bec0aa1 View commit details
    Browse the repository at this point in the history
  4. libpriv/kargs: Strengthen and simplify new kargs APIs

    Note this patch only touches the *new* APIs that aren't part of
    libostree.
    
    Now that we can use `g_ptr_array_find_with_equal_func`, we can drop our
    custom `_ostree_ptr_array_find`.
    
    Also strengthen our handling of values everywhere to handle the `NULL`
    case and properly support `KEYWORD` args. I ended up getting rid of
    `_ostree_kernel_arg_query_status` in the process since it made that
    assumption a lot and overall added more complexity than necessary.
    jlebon committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    28febce View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    71b976f View commit details
    Browse the repository at this point in the history