Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Start rewriting origin code in Rust #2388

Closed
wants to merge 1 commit into from
Closed

WIP: Start rewriting origin code in Rust #2388

wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

Builds on #2336

@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters cgwalters force-pushed the cxx-rs-origin branch 2 times, most recently from 60ccff7 to 147e0cf Compare December 22, 2020 20:23
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2021

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/build 147e0cf link /test build
ci/prow/unit 147e0cf link /test unit
ci/prow/build-clang 147e0cf link /test build-clang
ci/prow/fcos-e2e f8c0e70 link /test fcos-e2e
ci/prow/images f8c0e70 link /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cgwalters added a commit to cgwalters/rpm-ostree that referenced this pull request Feb 23, 2021
@cgwalters
daemon: Move some "deployment variant" generation to Rust
1dc6640 
More prep for coreos#2388

This was actually also my first time really trying out the
latest gtk-rs `glib::Variant` API, which is one of the major
things we need to use to progress oxidation more.
@cgwalters cgwalters mentioned this pull request Feb 23, 2021
Merged
openshift-merge-robot pushed a commit that referenced this pull request Feb 23, 2021
@cgwalters @openshift-merge-robot
daemon: Move some "deployment variant" generation to Rust
d8230bf 
More prep for #2388

This was actually also my first time really trying out the
latest gtk-rs `glib::Variant` API, which is one of the major
things we need to use to progress oxidation more.
@cgwalters cgwalters mentioned this pull request Mar 15, 2021
Closed
@openshift-ci-robot
Copy link
Collaborator

@cgwalters: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member Author

This is obsolete, going with another approach.

@cgwalters cgwalters closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinfan001 kelvinfan001 Awaiting requested review from kelvinfan001

@miabbott miabbott Awaiting requested review from miabbott

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @openshift-ci-robot