daemon: Move some "deployment variant" generation to Rust #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More prep for coreos#2388 This was actually also my first time really trying out the latest gtk-rs `glib::Variant` API, which is one of the major things we need to use to progress oxidation more.
jlebon
approved these changes
Feb 23, 2021
| .get_booted_deployment() | ||
| .map(|b| b.equal(deployment)) | ||
| .unwrap_or_default(); | ||
| dict.insert("booted", &booted); |
There was a problem hiding this comment.
This slightly changes the behaviour to always inserting the booted key instead of only if we're booted inside an OSTree. I vaguely remember having a reason to do that in #350, but I can't recall. So... I guess if nothing breaks, let's do it! :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More prep for #2388
This was actually also my first time really trying out the
latest gtk-rs
glib::VariantAPI, which is one of the majorthings we need to use to progress oxidation more.