[merged] RPMOSTreeSysroot: add "booted" entry to deployment variant #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the `status` command learned a `--json` option, we can pretty much avoid parsing human-readable output. The only piece of information that is missing from the JSON output compared to the output for humans is *which* deployment we're currently booted in. This patch fixes that shortcoming by adding a "booted" boolean variant to the deployment variant.
| { | ||
| booted_variant = rpmostreed_deployment_generate_variant (booted, booted_id, ot_repo, error); | ||
| if (!booted_variant) | ||
| return FALSE; |
There was a problem hiding this comment.
Indentation looks weird, stray 👉 tab ?
|
Utterly minor nits, otherwise 👍 |
|
⬆️ 🔧 |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
statuscommand learned a--jsonoption, we can prettymuch avoid parsing human-readable output. The only piece of information
that is missing from the JSON output compared to the output for humans
is which deployment we're currently booted in.
This patch fixes that shortcoming by adding a "booted" boolean variant
to the deployment variant.