build-sys: Symlink, not hard link ostree-container
#3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the debuginfo processing code in RHEL8 fails in
this scenario:
```
$ Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/rpm-ostree-2022.1-1.el8.x86_64
RPM build errors:
error: Installed (but unpackaged) file(s) found:
/usr/lib/debug/usr/bin/rpm-ostree-2022.1-1.el8.x86_64.debug.#dwz#.Iybgi6
Installed (but unpackaged) file(s) found:
/usr/lib/debug/usr/bin/rpm-ostree-2022.1-1.el8.x86_64.debug.#dwz#.Iybgi6
Child return code was: 1
```
Additionally, while hardlinks are conceptually cleaner, actually
because of SELinux they are highly likely to result in duplicate
disk usage. IOW we'd have to be sure `/usr/bin/ostree-container`
is also labeled `install_t`, otherwise ostree will compute different
digests for them.
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Jan 11, 2022
In fixing coreos/rpm-ostree#3323 I felt that it was a bit ugly we're installing `/usr/bin/ostree-container`. It's kind of an implementation detail. We want users to use `ostree container`. Let's support values outside of $PATH too. For example, this also ensures that TAB completion for `ost` expands to `ostree ` with a space.
cgwalters
added a commit
to cgwalters/ostree
that referenced
this pull request
Jan 12, 2022
In fixing coreos/rpm-ostree#3323 I felt that it was a bit ugly we're installing `/usr/bin/ostree-container`. It's kind of an implementation detail. We want users to use `ostree container`. Let's support values outside of $PATH too. For example, this also ensures that TAB completion for `ost` expands to `ostree ` with a space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the debuginfo processing code in RHEL8 fails in
this scenario:
Additionally, while hardlinks are conceptually cleaner, actually
because of SELinux they are highly likely to result in duplicate
disk usage. IOW we'd have to be sure
/usr/bin/ostree-containeris also labeled
install_t, otherwise ostree will compute differentdigests for them.