Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: Symlink, not hard link ostree-container #3323

Merged
merged 1 commit into from
Jan 11, 2022

Commits on Jan 11, 2022

  1. build-sys: Symlink, not hard link ostree-container

    It seems like the debuginfo processing code in RHEL8 fails in
    this scenario:
    
    ```
    $ Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/rpm-ostree-2022.1-1.el8.x86_64
    RPM build errors:
    error: Installed (but unpackaged) file(s) found:
       /usr/lib/debug/usr/bin/rpm-ostree-2022.1-1.el8.x86_64.debug.#dwz#.Iybgi6
        Installed (but unpackaged) file(s) found:
       /usr/lib/debug/usr/bin/rpm-ostree-2022.1-1.el8.x86_64.debug.#dwz#.Iybgi6
    Child return code was: 1
    ```
    
    Additionally, while hardlinks are conceptually cleaner, actually
    because of SELinux they are highly likely to result in duplicate
    disk usage.  IOW we'd have to be sure `/usr/bin/ostree-container`
    is also labeled `install_t`, otherwise ostree will compute different
    digests for them.
    cgwalters committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a50fde2 View commit details
    Browse the repository at this point in the history