Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check generated tmpfiles.d dir when removing package #4746

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Dec 29, 2023

When removing package, will also remove the generated tmpfile config under the rpm-ostree tmpfiles.d directory. Since #4697, we use the new directory like usr/lib/rpm-ostree/tmpfiles.d, but for old usr/lib/tmpfiles.d, failed with error: opendir(usr/lib/rpm-ostree/tmpfiles.d): No such file or directory.

With this patch, check if usr/lib/rpm-ostree/tmpfiles.d does not exist, will use old usr/lib/tmpfiles.d instead.

Also needs #4727.
Fixes: fedora-silverblue/issue-tracker#523

Copy link

openshift-ci bot commented Dec 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

With this patch, check if `usr/lib/rpm-ostree/tmpfiles.d` does not
exist, will use old `usr/lib/tmpfiles.d` instead.
Also needs coreos#4727.
Fixes: fedora-silverblue/issue-tracker#523
@cgwalters cgwalters merged commit 59297b1 into coreos:main Dec 30, 2023
17 checks passed
@HuijingHei HuijingHei deleted the remove-tmpfiles branch January 1, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken update since rpm-ostree-2023.12-1.fc39.x86_64
2 participants