Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken update since rpm-ostree-2023.12-1.fc39.x86_64 #523

Closed
karuboniru opened this issue Dec 26, 2023 · 10 comments · Fixed by coreos/rpm-ostree#4746
Closed

Broken update since rpm-ostree-2023.12-1.fc39.x86_64 #523

karuboniru opened this issue Dec 26, 2023 · 10 comments · Fixed by coreos/rpm-ostree#4746
Labels
bug Something isn't working f39 Related to Fedora 39 f40 Related to Fedora 40 upstream Issue reported, fixed or related to upstream projects

Comments

@karuboniru
Copy link

Describe the bug
rpm-ostree update will fail if executed from 39.20231224.0 of fedora/39/x86_64/testing/silverblue.

To Reproduce
Please describe the steps needed to reproduce the bug:

  1. Update to 39.20231224.0 of fedora/39/x86_64/testing/silverblue
  2. rpm-ostree update
  3. Got:
note: automatic updates (stage) are enabled
2 metadata, 0 content objects fetched; 788 B transferred in 1 seconds; 0 ?? content written
Checking out tree dd00e1d... done
Enabled rpm-md repositories: fedora-cisco-openh264 updates fedora updates-testing updates-archive
Importing rpm-md... done
rpm-md repo 'fedora-cisco-openh264' (cached); generated: 2023-03-14T10:57:01Z solvables: 4
rpm-md repo 'updates' (cached); generated: 2023-12-26T01:37:53Z solvables: 16861
rpm-md repo 'fedora' (cached); generated: 2023-11-01T00:12:39Z solvables: 70825
rpm-md repo 'updates-testing' (cached); generated: 2023-12-26T03:49:33Z solvables: 1721
rpm-md repo 'updates-archive' (cached); generated: 2023-12-26T01:55:57Z solvables: 18884
Resolving dependencies... done
Applying 2 overrides and 29 overlays
Processing packages... done
error: opendir(usr/lib/rpm-ostree/tmpfiles.d): 没有那个文件或目录

没有那个文件或目录 should be translation of no such file or directory

Expected behavior
It should bring me newer release

Screenshots
If applicable, add screenshots to help explain your problem.

OS version:

State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: no runs since boot
BootedDeployment:
● fedora:fedora/39/x86_64/testing/silverblue
                  Version: 39.20231224.0 (2023-12-24T02:18:05Z)
               BaseCommit: 0ff5bd75c66f0aa583ff6c66b27aa4d3cbc9f52884750331fa3f364aac723f31
             GPGSignature: Valid signature by E8F23996F23218640CB44CBE75CF5AC418B8E74C
      RemovedBasePackages: firefox firefox-langpacks 121.0-2.fc39
          LayeredPackages: fcitx5 fcitx5-autostart fcitx5-chinese-addons fcitx5-configtool fcitx5-gtk fcitx5-mozc fcitx5-qt zsh

Additional context
@karuboniru karuboniru added the bug Something isn't working label Dec 26, 2023
@karuboniru
Copy link
Author

karuboniru commented Dec 26, 2023 •
edited
Loading

I believe this is due to coreos/rpm-ostree#4697, it seems that the building process should populate files in /usr/lib/rpm-ostree while this hasn't done in this case cusing updating to fail.

Will check if the same is true for latest testing compose, if so maybe I should downvote the update to stop the package from landing to stable

Downvoted, at least we won't need to worry about breaking stable and things gets less urgent :)

@karuboniru karuboniru changed the title Can't update since (at least) 39.20231224.0 from fedora/39/x86_64/testing/silverblue Broken update since rpm-ostree-2023.12-1.fc39.x86_64 Dec 26, 2023
@travier
Copy link
Member

travier commented Dec 27, 2023

Wow, thanks for testing this out.

@travier travier mentioned this issue Dec 27, 2023
Merged
@travier travier added upstream Issue reported, fixed or related to upstream projects f39 Related to Fedora 39 f40 Related to Fedora 40 labels Dec 27, 2023
@cgwalters
Copy link

Should be fixed by coreos/rpm-ostree#4727 - we should make a new release soon.

HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Dec 29, 2023
@HuijingHei
Check old tmpfiles.d when removing package
50d6a9a 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
also need to handle old `usr/lib/tmpfiles.d`.

Fixes: fedora-silverblue/issue-tracker#523
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Dec 29, 2023
@HuijingHei
Check old tmpfiles.d when removing package
d0e46cb 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

Also needs coreos#4727.
Fixes: fedora-silverblue/issue-tracker#523
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Dec 29, 2023
@HuijingHei
Check old tmpfiles.d when removing package
238e02b 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

Also needs coreos#4727.
Fixes: fedora-silverblue/issue-tracker#523
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Dec 29, 2023
@HuijingHei
Check old tmpfiles.d when removing package
b0a86f3 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

With this patch, check if `usr/lib/rpm-ostree/tmpfiles.d` does not
exist, will use old `usr/lib/tmpfiles.d` instead.
Also needs coreos#4727.
Fixes: fedora-silverblue/issue-tracker#523
HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Dec 29, 2023
@HuijingHei
Check generated tmpfiles.d dir when removing package
47e6331 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

With this patch, check if `usr/lib/rpm-ostree/tmpfiles.d` does not
exist, will use old `usr/lib/tmpfiles.d` instead.
Also needs coreos#4727.
Fixes: fedora-silverblue/issue-tracker#523
@HuijingHei HuijingHei mentioned this issue Dec 29, 2023
Merged
@HuijingHei
Copy link

HuijingHei commented Dec 29, 2023 •
edited
Loading

Should be fixed by coreos/rpm-ostree#4727 - we should make a new release soon.

Check 4727 is included in 2023.12-1, maybe also need coreos/rpm-ostree#4746

HuijingHei added a commit to HuijingHei/rpm-ostree that referenced this issue Dec 29, 2023
@HuijingHei
Check generated tmpfiles.d dir when removing package
87a2a1d 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since coreos#4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

With this patch, check if `usr/lib/rpm-ostree/tmpfiles.d` does not
exist, will use old `usr/lib/tmpfiles.d` instead.
Also needs coreos#4727.
Fixes: fedora-silverblue/issue-tracker#523
cgwalters pushed a commit to coreos/rpm-ostree that referenced this issue Dec 30, 2023
@HuijingHei @cgwalters
Check generated tmpfiles.d dir when removing package
59297b1 
When removing package, will also remove the generated tmpfile
config under the rpm-ostree tmpfiles.d directory. Since #4697,
we use the new directory like `usr/lib/rpm-ostree/tmpfiles.d`, but
for old `usr/lib/tmpfiles.d`, failed with `error: opendir(usr/lib/
rpm-ostree/tmpfiles.d): No such file or directory`.

With this patch, check if `usr/lib/rpm-ostree/tmpfiles.d` does not
exist, will use old `usr/lib/tmpfiles.d` instead.
Also needs #4727.
Fixes: fedora-silverblue/issue-tracker#523
@travier
Copy link
Member

travier commented Jan 3, 2024

Should be fixed with https://github.com/coreos/rpm-ostree/releases/tag/v2024.1 when it lands in Fedora.

@cgwalters
Copy link

https://bodhi.fedoraproject.org/updates/FEDORA-2024-2a4f3dce00

@cgwalters cgwalters reopened this Jan 3, 2024
@HuijingHei
Copy link

Upgrade to rpm-ostree-2024.1-4.fc39.x86_64, can remove package successfully.

[root@cosa-devsh ~]# rpm -q rpm-ostree
rpm-ostree-2023.11-1.fc39.x86_64
[root@cosa-devsh ~]# rpm-ostree override replace https://bodhi.fedoraproject.org/updates/FEDORA-2024-2a4f3dce00
[root@cosa-devsh ~]# reboot
[core@cosa-devsh ~]$ rpm -q rpm-ostree
rpm-ostree-2024.1-4.fc39.x86_64

[core@cosa-devsh ~]$ ls /usr/lib/rpm-ostree
ls: cannot access '/usr/lib/rpm-ostree': No such file or directory

[core@cosa-devsh ~]$ sudo rpm-ostree override remove chrony
Checking out tree 621d18a... done
Resolving dependencies... done
Applying 3 overrides
Processing packages... done
Running pre scripts... done
Running post scripts... done
Running posttrans scripts... done
Writing rpmdb... done
Writing OSTree commit... done
Staging deployment... done
Pruned images: 0 (layers: 51)
Freed: 2.2 MB (pkgcache branches: 0)
Removed:
  chrony-4.5-1.fc39.x86_64
Use "rpm-ostree override reset" to undo overrides
Run "systemctl reboot" to start a reboot

HuijingHei added a commit to HuijingHei/fedora-coreos-config that referenced this issue Jan 8, 2024
@HuijingHei
tests: add rpm-ostree override remove test
ff98bea 
Add integration test for fedora-silverblue/issue-tracker#523
@HuijingHei HuijingHei mentioned this issue Jan 8, 2024
Closed
@travier travier reopened this Jan 8, 2024
@travier
Copy link
Member

travier commented Jan 8, 2024 •
edited
Loading

This may be a different issue, but this one is now blocked by https://bugzilla.redhat.com/show_bug.cgi?id=2252000, at least until we complete the investigation.

@travier
Copy link
Member

travier commented Jan 8, 2024

Testing https://bodhi.fedoraproject.org/updates/FEDORA-2024-2a4f3dce00 resolves this issue would be nice.

@HuijingHei HuijingHei mentioned this issue Jan 24, 2024
Closed
@jlebon jlebon mentioned this issue Jan 30, 2024
Merged
@travier
Copy link
Member

travier commented Oct 30, 2024

This should have been fixed now.

@travier travier closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working f39 Related to Fedora 39 f40 Related to Fedora 40 upstream Issue reported, fixed or related to upstream projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check generated tmpfiles.d dir when removing package HuijingHei/rpm-ostree
4 participants
@cgwalters @karuboniru @HuijingHei @travier