livefs: add warning that /etc won't be preserved #986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the whole premise of livefs is that you stay in your deployment just a little longer, it becomes much more likely for people to run into coreos#40 (myself included). Printing such a notice was discussed in the initial livefs design discussions: coreos#639.
|
💔 Test failed - status-atomicjenkins |
dustymabe
reviewed
Sep 12, 2017
| @@ -659,6 +659,9 @@ livefs_transaction_execute_inner (LiveFsTransaction *self, | |||
| return FALSE; | |||
| } | |||
|
|
|||
| /* XXX: right now we don't have a good solution for this */ | |||
| rpmostree_output_message ("WARNING: changes to /etc are not currently preserved!"); | |||
There was a problem hiding this comment.
more info? are not preserved in what situation?
There was a problem hiding this comment.
See the linked issue: #40. This is not unique to livefs, it just makes it more obvious.
There was a problem hiding this comment.
i'm just saying that a little more info for the user in this situation wouldn't be bad. i.e. any changes made to /etc before reboot will not be preserved after reboot!
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the whole premise of livefs is that you stay in your deployment
just a little longer, it becomes much more likely for people to run into
#40 (myself included).
Printing such a notice was discussed in the initial livefs design
discussions: #639.