-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
livefs: add warning that /etc won't be preserved #986
Conversation
Since the whole premise of livefs is that you stay in your deployment just a little longer, it becomes much more likely for people to run into coreos#40 (myself included). Printing such a notice was discussed in the initial livefs design discussions: coreos#639.
💔 Test failed - status-atomicjenkins |
@@ -659,6 +659,9 @@ livefs_transaction_execute_inner (LiveFsTransaction *self, | |||
return FALSE; | |||
} | |||
|
|||
/* XXX: right now we don't have a good solution for this */ | |||
rpmostree_output_message ("WARNING: changes to /etc are not currently preserved!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more info? are not preserved in what situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the linked issue: #40. This is not unique to livefs, it just makes it more obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm just saying that a little more info for the user in this situation wouldn't be bad. i.e. any changes made to /etc before reboot will not be preserved after reboot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Tweaked in #988.
@rh-atomic-bot retry |
☀️ Test successful - status-atomicjenkins |
Since the whole premise of livefs is that you stay in your deployment
just a little longer, it becomes much more likely for people to run into
#40 (myself included).
Printing such a notice was discussed in the initial livefs design
discussions: #639.