Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have upgrade only do /etc merge just before reboot #40

Closed
cgwalters opened this issue Oct 30, 2014 · 8 comments
Closed

Have upgrade only do /etc merge just before reboot #40

cgwalters opened this issue Oct 30, 2014 · 8 comments
Labels
kind/enhancement

Comments

@cgwalters
Copy link
Member

cgwalters commented Oct 30, 2014 •
edited
Loading

PR: ostreedev/ostree#1503

--

If an admin runs "atomic upgrade", then makes changes to /etc, then reboots, those changes are "lost" (they're still in the old tree).

Fixing this is a bit nontrivial. One simple approach would be to encourage "atomic upgrade -r". Or alternatively, split "atomic prepare-upgrade" -> "atomic apply-upgrade". (The latter gets into making atomic a daemon, so we can use a systemctl isolate target for doing the /etc merging just before reboot)
This was referenced Nov 10, 2014
Closed
Open
@stefwalter stefwalter mentioned this issue Sep 30, 2015
Closed
@giuseppe
Copy link
Contributor

this is a comment we had in another conversation, I add here to not get it lost: what do you think if we remount /etc as read-only after the upgrade is done? Postponing the merge before the reboot seems a bit risky, as the users won't have the chance to deal with possible errors and do we want to block the reboot in that case?

@cgwalters
Copy link
Member Author

Yeah, would likely work...we'd just need to make sure the operating system content was fine with read-only /etc. Things like /etc/resolv.conf would need to live outside it, etc. This is obviously ground that others have covered before, but making it the default in e.g. Fedora would be a major change. I'd support it though.

@cgwalters
Copy link
Member Author

This was also hitting the Cockpit tests.

@jlebon jlebon mentioned this issue Aug 11, 2016
Closed
@vtolstov
Copy link

Any steps in this issue? (I lost some changes because i forget about reboot when doing upgrade =()

@cgwalters cgwalters mentioned this issue Jan 4, 2017
Closed
@cgwalters
Copy link
Member Author

CC #702

@cgwalters cgwalters mentioned this issue Apr 25, 2017
Closed
This was referenced May 8, 2017
Closed
Closed
@cgwalters
Copy link
Member Author

I think we should fix (most of) this in libostree - main discussion should be in ostreedev/ostree#545

jlebon added a commit to jlebon/rpm-ostree that referenced this issue Sep 12, 2017
@jlebon
livefs: add warning that /etc won't be preserved
1413677 
Since the whole premise of livefs is that you stay in your deployment
just a little longer, it becomes much more likely for people to run into
coreos#40 (myself included).

Printing such a notice was discussed in the initial livefs design
discussions: coreos#639.
@jlebon jlebon mentioned this issue Sep 12, 2017
Closed
rh-atomic-bot pushed a commit that referenced this issue Sep 12, 2017
@jlebon @rh-atomic-bot
livefs: add warning that /etc won't be preserved
ab3b9ea 
Since the whole premise of livefs is that you stay in your deployment
just a little longer, it becomes much more likely for people to run into
#40 (myself included).

Printing such a notice was discussed in the initial livefs design
discussions: #639.

Closes: #986
Approved by: cgwalters
rh-atomic-bot pushed a commit that referenced this issue Sep 12, 2017
@jlebon @rh-atomic-bot
livefs: add warning that /etc won't be preserved
2a5ecf7 
Since the whole premise of livefs is that you stay in your deployment
just a little longer, it becomes much more likely for people to run into
#40 (myself included).

Printing such a notice was discussed in the initial livefs design
discussions: #639.

Closes: #986
Approved by: cgwalters
@cgwalters cgwalters mentioned this issue Oct 6, 2017
Closed
@jlebon jlebon mentioned this issue Dec 5, 2017
Closed
cgwalters added a commit to cgwalters/ostree that referenced this issue Mar 18, 2018
@cgwalters
WIP: Add concept of "staged" deployment
df530e4 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
@cgwalters cgwalters mentioned this issue Mar 18, 2018
Closed
@cgwalters
Copy link
Member Author

PR in ostreedev/ostree#1503

@cgwalters
Copy link
Member Author

Closing this one in favor of ostreedev/ostree#545

cgwalters added a commit to cgwalters/ostree that referenced this issue Mar 20, 2018
@cgwalters
WIP: Add concept of "staged" deployment
c68f28f 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
cgwalters added a commit to cgwalters/ostree that referenced this issue Mar 21, 2018
@cgwalters
WIP: Add concept of "staged" deployment
feca528 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
cgwalters added a commit to cgwalters/ostree that referenced this issue Mar 25, 2018
@cgwalters
WIP: Add concept of "staged" deployment
009dec7 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
cgwalters added a commit to cgwalters/ostree that referenced this issue Mar 26, 2018
@cgwalters
WIP: Add concept of "staged" deployment
2814ca0 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
cgwalters added a commit to cgwalters/ostree that referenced this issue Mar 27, 2018
@cgwalters
WIP: Add concept of "staged" deployment
4e0bfaa 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
cgwalters added a commit to cgwalters/ostree that referenced this issue Apr 5, 2018
@cgwalters
WIP: Add concept of "staged" deployment
57e6138 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
cgwalters added a commit to cgwalters/ostree that referenced this issue Apr 6, 2018
@cgwalters
WIP: Add concept of "staged" deployment
c83b97f 
Add API to write a deployment state to `/run/ostree/staged-deployment`,
along with a systemd service which runs at shutdown time.

Just compile tested, still WIP.

For: coreos/rpm-ostree#40
@jlebon jlebon mentioned this issue Jan 29, 2019
Closed
@ricardosalveti ricardosalveti mentioned this issue Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giuseppe @cgwalters @vtolstov