Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KubeVirt platform artifact and image information #41

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Mar 14, 2022

Artifact: KubeVirt containerDisks have a normal qcow2 image as base,
similar configured like for OpenStack.

Image: KubeVirt consumes directly a qcow2 disk inside a container which
is described in the images section. It is based on the qcow2 from the
base artifacts for kubevirt.

This schema extension is needed to include informations about containerDisks created in coreos/coreos-assembler#2750.

HyperShift uses this information in rhcos.json to determine which rhcos image to pull for the KubeVirt platform (similart to what it does for AWS).

The final image information looks like this:

                "kubevirt": {
                    "image": "quay.io/openshift-release-dev/rhcos@sha256:67a81539946ec0397196c145394553b8e0241acf27b14ae9de43bc56e167f773"
                }

Building the intaller with this version and a corresponding rhcos.json give the expected results:

$ ./bin/openshift-install coreos print-stream-json | jq -r '.architectures.x86_64.images.kubevirt'
{
  "image": "quay.io/openshift-release-dev/rhcos@sha256:67a81539946ec0397196c145394553b8e0241acf27b14ae9de43bc56e167f773"
}

and

$ ./bin/openshift-install coreos print-stream-json | jq -r '.architectures.x86_64.artifacts.kubevirt'
{
  "release": "33.20201201.3.0",
  "formats": {
    "qcow2.xz": {
      "disk": {
        "location": "https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/33.20201201.3.0/x86_64/fedora-coreos-33.20201201.3.0-kubevirt.x86_64.qcow2.xz",
        "signature": "https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/33.20201201.3.0/x86_64/fedora-coreos-33.20201201.3.0-kubevirt.x86_64.qcow2.xz.sig",
        "sha256": "2be55c5aa1f53eb9a869826dacbab75706ee6bd59185b935ac9be546cc132a85"
      }
    }
  }
}

@rmohr
Copy link
Member Author

rmohr commented Mar 14, 2022

/cc @travier
/cc @miabbott

I am unsure if I should also include tags, but digest are most likely preferred.

@rmohr
Copy link
Member Author

rmohr commented Mar 14, 2022

/cc @davidvossel

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

release/release.go Show resolved Hide resolved
release/release_test.go Outdated Show resolved Hide resolved
stream/stream_utils.go Outdated Show resolved Hide resolved
Artifact: KubeVirt containerDisks have a normal qcow2 image as base,
similar configured like for OpenStack.

Image: KubeVirt consumes directly a qcow2 disk inside a container which
is described in the images section. It is based on the qcow2 from the
base artifacts for kubevirt.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@cgwalters cgwalters merged commit 9dfda84 into coreos:main Mar 15, 2022
@rmohr
Copy link
Member Author

rmohr commented Mar 15, 2022

@cgwalters thanks for the reviews! Do you know when a new release tag will be created?

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits. @rmohr, if you can do a quick followup PR, I'll tag a release afterward.

stream/stream.go Show resolved Hide resolved
release/release.go Show resolved Hide resolved
@bgilbert
Copy link
Contributor

Followup in #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants