Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups on kubevirt related structs #42

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Minor cleanups on kubevirt related structs #42

merged 1 commit into from
Mar 15, 2022

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Mar 15, 2022

  • Remove omitempty from Image string
  • Restore alphabetical order in the Images struct

@rmohr
Minor cleanups on kubevirt related structs
66eb782 
* Remove `omitempty` from Image string
* Restore alphabetical order in the Images struct

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@rmohr
Copy link
Member Author

rmohr commented Mar 15, 2022

/cc @bgilbert

Thanks!

@bgilbert bgilbert mentioned this pull request Mar 15, 2022
Merged
bgilbert
bgilbert approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bgilbert bgilbert merged commit d8d6a46 into coreos:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgilbert bgilbert bgilbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmohr @bgilbert