Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar new design #302

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Search bar new design #302

merged 10 commits into from
Oct 23, 2023

Conversation

ggsawatyanon
Copy link
Contributor

Summary

This pull request is the first step towards implementing the new Search Bar design (according to the Figma).

  • Implemented search bar new design
  • Implemented new design for search pages + Nav bar but kept old design for home page (according to Figma).
  • Fixed width issue for navbar's search bar
  • Fixed placeholder text issue for navbar search bar

Test Plan

Old design for home:
Screenshot 2023-10-01 at 23 59 40

New design for search pages:
image

Navbar searchbar design:
Screenshot 2023-10-01 at 23 59 53

Notes

  • Deployment check failed: this will be a future fix – it's a result of the previously existing code for Autocomplete.tsx having a lot of code that isn't used (Menu). So can be fixed by deleting a lot of the unused code.

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 2, 2023

[diff-counting] Significant lines: 200.

@ggsawatyanon ggsawatyanon temporarily deployed to staging October 12, 2023 17:50 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Visit the preview URL for this PR (updated for commit c893136):

https://cu-apts-staging--pr302-searchbarredesign-h339b8ei.web.app

(expires Mon, 30 Oct 2023 20:10:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

@ggsawatyanon ggsawatyanon temporarily deployed to staging October 12, 2023 18:03 — with GitHub Actions Inactive
@ggsawatyanon ggsawatyanon temporarily deployed to staging October 12, 2023 18:06 — with GitHub Actions Inactive
@ggsawatyanon
Copy link
Contributor Author

Fixed failed deployment checks + made input adornment clickable + cleared search bar when searched

@ggsawatyanon ggsawatyanon requested a review from mluo24 October 12, 2023 18:11
Copy link
Contributor

@cyrus14 cyrus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Grace! Great job on your code changes. You've done a remarkable job with these specific enhancements: firstly, implementing a new design for the search bar, a crucial UI upgrade. Secondly, your work on the new design for search pages and the navigation bar, aligned with the Figma design, showcases your dedication to design consistency. Additionally, you've effectively resolved the width issue in the navbar's search bar, ensuring it displays correctly, and addressed the placeholder text issue, significantly improving the user experience. Your code is well-structured and clean, and your contributions are much appreciated. Keep up the great work!

@thuypham03 thuypham03 temporarily deployed to staging October 22, 2023 19:50 — with GitHub Actions Inactive
@jesshan700
Copy link
Contributor

Hey Grace! This is a very important feature for our website - the code looks clean this implementation definitely makes it easier for the user to see where they can search!

Copy link
Contributor

@cyrus14 cyrus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Grace! Your recent pull request is a great step towards implementing the new Search Bar design. You've successfully brought the new design to life, extended it to search pages and the navigation bar while keeping the old design for the home page in line with Figma's guidelines. Your attention to detail is evident in fixing the width and placeholder text issues in the navbar's search bar, and your commitment to quality and design consistency is highly appreciated. Keep up the excellent work, Grace – looking forward to more of your valuable contributions.

@ggsawatyanon ggsawatyanon temporarily deployed to staging October 23, 2023 20:07 — with GitHub Actions Inactive
@cyrus14 cyrus14 merged commit 57a4b55 into main Oct 23, 2023
6 checks passed
@cyrus14 cyrus14 deleted the searchBarRedesign branch October 23, 2023 20:12
@thuypham03 thuypham03 mentioned this pull request Nov 6, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants