-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar new design #302
Conversation
Yarn workspace frontend build error: 'Menu' is assigned a value but never used
This reverts commit 112b6ac.
[diff-counting] Significant lines: 200. |
Visit the preview URL for this PR (updated for commit c893136): https://cu-apts-staging--pr302-searchbarredesign-h339b8ei.web.app (expires Mon, 30 Oct 2023 20:10:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 096ac87b789b31770a01964fe0aaa92d563b9353 |
Fixed failed deployment checks + made input adornment clickable + cleared search bar when searched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Grace! Great job on your code changes. You've done a remarkable job with these specific enhancements: firstly, implementing a new design for the search bar, a crucial UI upgrade. Secondly, your work on the new design for search pages and the navigation bar, aligned with the Figma design, showcases your dedication to design consistency. Additionally, you've effectively resolved the width issue in the navbar's search bar, ensuring it displays correctly, and addressed the placeholder text issue, significantly improving the user experience. Your code is well-structured and clean, and your contributions are much appreciated. Keep up the great work!
Hey Grace! This is a very important feature for our website - the code looks clean this implementation definitely makes it easier for the user to see where they can search! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Grace! Your recent pull request is a great step towards implementing the new Search Bar design. You've successfully brought the new design to life, extended it to search pages and the navigation bar while keeping the old design for the home page in line with Figma's guidelines. Your attention to detail is evident in fixing the width and placeholder text issues in the navbar's search bar, and your commitment to quality and design consistency is highly appreciated. Keep up the excellent work, Grace – looking forward to more of your valuable contributions.
Summary
This pull request is the first step towards implementing the new Search Bar design (according to the Figma).
Test Plan
Old design for home:
New design for search pages:
Navbar searchbar design:
Notes