Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI changes to support the GHC WASM/WASI backend #85

Merged
merged 3 commits into from
Apr 30, 2023

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented Apr 30, 2023

This fixes compilation with the new WASM/WASI backend in GHC 9.6 with an approach as in haskell/time#209.

I have only compiled this for x86_64-linux and wasm32-wasi; it might make sense to first add CI for Windows/macOS/etc. before merging this to ensure it does not break on those systems.

@CetinSert CetinSert merged commit fad77ab into corsis:master Apr 30, 2023
@amesgen amesgen deleted the wasi branch April 30, 2023 22:07
@CetinSert
Copy link
Member

@amesgen – do we need a hackage release?

@amesgen
Copy link
Contributor Author

amesgen commented May 1, 2023

That would be neat! As mentioned in the PR description, CI for macOS/Windows (or even more systems) might be neat before releasing this PR. I can create a PR for that if you want.

@CetinSert
Copy link
Member

I can create a PR for that if you want.

@amesgen – please do so 😃!

@georgefst
Copy link

@amesgen – do we need a hackage release?

With #86 merged, is there anything blocking a release?

@CetinSert
Copy link
Member

@georgefst
@amesgen

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants