Creating label native-histogram-sample on the cortex_discarded_samples_total to keep track of discarded native histogram samples
#5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
native-histogram-metric
branch
from
1b325bc to
72bab21
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
changed the title
native-histogram-sample on the cortex_discarded_samples_total to keep track of discarded native histogram samples
alanprot
force-pushed
the
native-histogram-metric
branch
from
4522c6c to
1252038
Compare
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
…ples_total` to keep track of discarded native histogram samples (cortexproject#5289) * Create new reason on the discarted sample metric - native histogram Signed-off-by: Alan Protasio <alanprot@gmail.com> * fix build Signed-off-by: Alan Protasio <alanprot@gmail.com> * fix proto Signed-off-by: Alan Protasio <alanprot@gmail.com> * Resetting histogram Signed-off-by: Alan Protasio <alanprot@gmail.com> * changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Apr 28, 2023
…ples_total` to keep track of discarded native histogram samples (cortexproject#5289) * Create new reason on the discarted sample metric - native histogram Signed-off-by: Alan Protasio <alanprot@gmail.com> * fix build Signed-off-by: Alan Protasio <alanprot@gmail.com> * fix proto Signed-off-by: Alan Protasio <alanprot@gmail.com> * Resetting histogram Signed-off-by: Alan Protasio <alanprot@gmail.com> * changelog Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Signed-off-by: Ben Ye <benye@amazon.com>
|
Umm, after taking another look at this I think this metric is not working at all. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Update Cortex proto with the new native histogram format from prometheus
Create a new reason on the discarded metric:
native-histogram-sample.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]