Add user label to ruler query and write metrics #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinlin123
reviewed
May 1, 2023
|
The change looks okay to me. Please make sure we mention the metrics we are going to change in the changelog. |
friedrichg
reviewed
May 2, 2023
alvinlin123
suggested changes
May 4, 2023
| @@ -157,6 +157,7 @@ jobs: | |||
| docker pull quay.io/cortexproject/cortex:v1.14.0 | |||
| docker pull quay.io/cortexproject/cortex:v1.14.1 | |||
| docker pull quay.io/cortexproject/cortex:v1.15.0 | |||
| docker pull quay.io/cortexproject/cortex:v1.15.1 | |||
There was a problem hiding this comment.
this looks like a change that is already in cortexproject:master
.gitignore
Outdated
| cmd/cortex/cortex | ||
| cmd/query-tee/query-tee | ||
| cmd/thanosconvert/thanosconvert | ||
| cmd/test-exporter/test-exporter-* |
There was a problem hiding this comment.
this looks like a change that is already in cortexproject:master
rajagopalanand
force-pushed
the
master
branch
3 times, most recently
from
85b384a to
f443580
Compare
…ser level Signed-off-by: Anand Rajagopal <anrajag@amazon.com>
alvinlin123
approved these changes
May 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adding user label to cortex_ruler_queries_failed_total, cortex_ruler_queries_total, cortex_ruler_write_requests_failed_total, cortex_ruler_write_requests_total metrics. This would allow for better tracking of failures at a user level
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]