Remove user specific evaluation metrics when rule manager is removed #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanlodovice
force-pushed
the
cleanup-metrics
branch
5 times, most recently
from
38ca8ec to
e4f2704
Compare
yeya24
reviewed
Feb 14, 2024
Signed-off-by: Emmanuel Lodovice <lodovice@amazon.com>
emanlodovice
force-pushed
the
cleanup-metrics
branch
from
e4f2704 to
e1c1d01
Compare
|
LGTM |
rajagopalanand
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In #5312 the rule evaluation metrics related to queries and append became per user metrics. But unlike other per user metrics, the multitenant manager is NOT currently deleting these metrics when the ruler manager is deleted leaving multiple dangling metrics. In this PR, we delete these dangling metrics when the rule manager is deleted.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]