Changing return code from storegateway for CMK errors #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
kms-handling-access-denied-storegateway
branch
from
9bc4569 to
a878b61
Compare
…nDenied Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
kms-handling-access-denied-storegateway
branch
from
a878b61 to
3854099
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
kms-handling-access-denied-storegateway
branch
from
28485bb to
c7f7ef1
Compare
alanprot
force-pushed
the
kms-handling-access-denied-storegateway
branch
from
c7f7ef1 to
4833995
Compare
alanprot
changed the title
alanprot
force-pushed
the
kms-handling-access-denied-storegateway
branch
from
feaa2cf to
25be4da
Compare
alanprot
force-pushed
the
kms-handling-access-denied-storegateway
branch
from
25be4da to
f1107b2
Compare
yeya24
reviewed
Jul 6, 2023
| @@ -299,25 +299,22 @@ func (u *BucketStores) Series(req *storepb.SeriesRequest, srv storepb.Store_Seri | |||
| } | |||
|
|
|||
| store := u.getStore(userID) | |||
| userBkt := bucket.NewUserBucketClient(userID, u.bucket, u.limits) | |||
There was a problem hiding this comment.
We are initializing a new bkt client every Series request? Can we just use u.bucket here?
There was a problem hiding this comment.
I had to do this to unwrap the error, but creating this here is just creating an object (it does not do anything).
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alvinlin123
approved these changes
Jul 6, 2023
yeya24
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is a follow up of #5420 and basically change the return code from
ResourceExhaustedtoPermissionDenied.Also adding the changelog that was forgotten on the last PR.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]