Fix param_query omitted in query frontend query stats log #5655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We found that
param_query
unabled to be logged in query frontend in latest Cortex version caused by #5622.The bug is that,
queryFields
is of type[]string
,fields
is of type[]interface{}
.This append will add
queryFields []string
as a single element tofields
slice, causing the params unable to be logged.The correct way is to add key, value as two separate fields using
fields = append(fields, queryFields...)
.A unit test case has been added to ensure the correctness.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]