Add querier.max-subquery-steps to make subquery step size check optional #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
alanprot
approved these changes
Nov 16, 2023
|
Thanks.. make sense to me! But maybe in the future we should add a default as we know this can cause problems? |
I see. I want to see if we can propose some kind of limit in Prometheus and keep Cortex behavior the same as Prometheus on this limit... Ideally this issue should be caught by samples limit, but there might be edge cases depending on actual query |
|
I will merge this one and keep this feature disabled in this release. We can think about whether we want to turn it on by defualt in the future |
yeya24
added a commit
to yeya24/cortex
that referenced
this pull request
Nov 16, 2023
…nal (cortexproject#5656) * add querier.max-subquery-steps to make subquery step size check optional Signed-off-by: Ben Ye <benye@amazon.com> * update Signed-off-by: Ben Ye <benye@amazon.com> * disable subquery step size check by default, make it optional Signed-off-by: Ben Ye <benye@amazon.com> * fix integ test and add changelog Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
3 tasks
yeya24
added a commit
that referenced
this pull request
Nov 16, 2023
* Fix param_query omitted in query frontend query stats log (#5655) * fix param_query not logged in query stats log Signed-off-by: Ben Ye <benye@amazon.com> * fix lint Signed-off-by: Ben Ye <benye@amazon.com> * fix unit test of user agent Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> * Add querier.max-subquery-steps to make subquery step size check optional (#5656) * add querier.max-subquery-steps to make subquery step size check optional Signed-off-by: Ben Ye <benye@amazon.com> * update Signed-off-by: Ben Ye <benye@amazon.com> * disable subquery step size check by default, make it optional Signed-off-by: Ben Ye <benye@amazon.com> * fix integ test and add changelog Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com> * bump RC version to 1.16.0-rc.1 Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Expose
querier.max-subquery-stepssubquery max allowed steps limit as a flag. This default limit is 0, which disables this check so that we can keep the behavior the same as previous releases and PrometheusWhich issue(s) this PR fixes:
Fixes #5651
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]