-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser Sync won't load bundle.js on external devices for dev build #205
Comments
Does the external address work at all? If you use it on the local device with the external address does it load? |
Yes the external address works on my local device. Thanks for your response. |
This is interesting timing because I was considering removing browsersync since it complicates configuration and I suspect few are using its sync features. That said, great catch. I've reproduced the issue. I don't have a fix idea at this point, but thanks for the heads up. |
I have a feeling that it is something to do with the webpack-dev-middleware package. I'll let you know if I find a fix for this issue. Cheers |
Ok when I edit the |
Yep, you're on the right track. That's where I was focused as well. I hoped removing the publicPath altogether would resolve it, but that didn't fix it for me. It does appear we don't need publicPath anymore. I could have sworn it was necessary before. |
An even better fix is to simply comment out the |
Ah, indeed! Problem is, the public path was added to resolve this issue in dev: #125 Any ideas on how to support both use cases? |
A possible solution could be to change the |
I'm not getting this error when I leave out the public path. Is it still an issue? Are you able to test this locally? |
"I'm not getting this error..." Which error are you referring to? |
I am able to load webfonts without any issues. |
Ignore that last post I can see the blob: prefix on the url now. I'll look into this further |
There needs to be a way to get the ip address dynamically using node. Do you know of an easy way to do this? |
We should be able to pull this off with the |
Hi ketch, |
*kwelch |
Ok so I've figured out a work around to fetch the ip address dynamically for now (based on this post) So after line 3 in
Then I replace the line If there is a more succinct way of getting the same result I'd love to hear it. |
They may be |
Awesome, I look forward to seeing what you come up with! |
Please see comment on #125, I did my best to go into detail on what I was seeing and why. |
This can be closed with that PR merge. |
Node version: 6.2.2
npm version: 3.9.5
Operating system: MAC OSX El Capitan (v 10.11.15)
Command line used: npm start -s
Steps to reproduce:
What I've tried:
Note:
Browser sync hot reloading works fine with the production build. It's the development environment that I appear to be having issues with .
Really love this starter kit and want to use it so hope it's an issue that I can get resolved. Cheers
Sunny
The text was updated successfully, but these errors were encountered: