-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images don't show as background-image when using css-loader sourceMap option #81
Comments
I see multiple options:
I lean toward option 2. Option 1 means debugging CSS would be difficult. Thoughts? |
Minifying only in production build sounds good. (Without sourcemaps) On Mon, Mar 21, 2016 at 12:43 PM Cory House notifications@github.com
|
Just occurred to me - the reason sourcemaps are so useful is we're compiling from SASS. So without them, you're lost during dev. Now I'm torn. We basically have a choice between:
After thinking about this more, I think keeping sourcemaps on is the best approach. We'd certainly want them if it weren't for this (hopefully short-term) bug. |
I'd just like to add that "those with this issue" should be 100% of people At least we should have a FAQ in the README, I guess. On Mon, Mar 21, 2016 at 1:57 PM Cory House notifications@github.com wrote:
|
Just disable css sourceMaps and it works |
I'd also vote for option #2 fwiw. |
This is a fix webpack-contrib/style-loader#96 |
@Strate Great to hear! Hopefully they accept that PR soon. |
PR #207 uses the fix quick fix discussed in webpack-contrib/style-loader#96, so this item should be resolved. I can re-test to verify. |
Validated with the update to set webpack path dynamically, relative background images work. Closing. |
Awesome! Thanks Kyle! |
Reported here: webpack-contrib/css-loader#216
Discussed here: webpack-contrib/style-loader#55
I simply removed sourceMap from my build. I think it's worth it at least documenting this big caveat, but I'd vote to remove CSS sourceMap completely.
The text was updated successfully, but these errors were encountered: