Support bootstrap glyiphicons without hardcoding public path

[kwelch]

So this removes the public path explicitly set causing issues (#181 & #205)

This is a very hacky solution in my mind.

Special Notes

• Adding bootstrap to dependancies => this was intention since I didn't expect the bootstrap part to "live"
• I was able to run on external device, but I was not seeing bootstrap icons re-tested and this works

[coveralls]

Coverage remained the same at 98.501% when pulling 4029e8b on kwelch:bootstrap-support into 8c5a173 on coryhouse:master.

[coryhouse]

Where is this variable used?

[kwelch]

This is dynamically sets the public path at runtime allowing proper resolving for loaders.

Found it in the issue for relative paths in style-loader.
Further explaination: webpack-contrib/style-loader#96 (comment)

Honestly, I am not a fan of this outside of the fact that it does work. This will allow proper support icon support to fix #125, but it also does so in a way that does not cause other breaking changes as seen in #181 & #205.

[coryhouse]

Ah, I see that webpack_public_path is a magic global.

I'd suggest renaming bootstrap-public-path to webpack-public-path and adding a comment inside that explains why its being set dynamically and includes a link to relevant issues and the docs that explain what webpack_public_path is.

Thanks so much for all your hard work on this Kyle! 💯

[kwelch]

I can revert the bootstrap specific changes if you want to move forward with this.

[coveralls]

Coverage remained the same at 98.501% when pulling 2f6f679 on kwelch:bootstrap-support into 8c5a173 on coryhouse:master.

[coryhouse]

Great work Kyle! Thanks for all your help on this! 👍