feat: switch hello-cosmo-go to WASI preview2 tinygo w/ wash build #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work is underway in wash to enable building components with the tinygo toolchain. This means that running `wash build` should be enough for people to get a preview2 tinygo component built and signed. However, the support in this repository is *pre* WASI resources landing, so a slightly older version of some dependencies (specifically, wasi:io/streams) must be used. This commit updates the hello-cosmo-go example to use the options that will work soon (tm) in wash, and the necessary WIT to make the actor compile properly. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
10 tasks
|
@vados-cosmonic I don't think the wasmcloud host we use with wash is compatible with the changes here(?) As far as I know, we should be using wasmtime v0.13 stuff everywhere: wit definitions, adapter, and so on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Reviewer
@ricochet
Feature or Problem
Work is underway in wash to enable building components with the tinygo toolchain. This means that running
wash buildshould be enough for people to get a preview2 tinygo component built and signed.However, the support in this repository is pre WASI resources landing, so a slightly older version of some
dependencies (specifically, wasi:io/streams) must be used.
This commit updates the hello-cosmo-go example to use the options that will work soon (tm) in wash, and the necessary WIT to make the actor compile properly.
Related Issues
wasmCloud/wash#758
Release Information
Consumer Impact
Consumers should be able to build WASI preview2 components for TinyGo with
wash buildTesting
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
Verified manually locally