Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

TINYGO + WASI + wash build = YES PLEASE #758

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

jordan-rash
Copy link
Member

Feature or Problem

Trying to solve #512

Release Information

This adds the wasm_target value to the [tinygo] wasmcloud.toml section. Defaults to wasm but excepts wasm or wasi

Consumer Impact

Testing

I would definitely not code review this and set to auto-merge...i am highly skilled in Rust and it would be a waste of everyones time................

Built on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

Tested on platform(s)

  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
  • x86_64-windows

@jordan-rash jordan-rash linked an issue Sep 1, 2023 that may be closed by this pull request
@jordan-rash
Copy link
Member Author

Disclaimer: if you ask my why I did something, the answer is 99% chance, "I don't know"

ricochet
ricochet previously approved these changes Sep 1, 2023
@brooksmtownsend
Copy link
Member

@jordan-rash looks like it's correctly failing a test, assuming that the target is always going to be None, once that's fixed this should be good to go!

brooksmtownsend
brooksmtownsend previously approved these changes Sep 1, 2023
@jordan-rash
Copy link
Member Author

@jordan-rash looks like it's correctly failing a test, assuming that the target is always going to be None, once that's fixed this should be good to go!

Ha, I'll try and figure that out tonight

@brooksmtownsend
Copy link
Member

@jordan-rash bump! 😄

@connorsmith256 connorsmith256 requested a review from a user October 4, 2023 02:23
@vados-cosmonic
Copy link
Contributor

Hey @ricochet just checking that you're fine using this by thurs without it merging (IIRC we weren't intending to cut a new release of wash for this, right?)

@vados-cosmonic
Copy link
Contributor

Hey @connorsmith256 not sure why this branch is still showing conflicts (I still can't see what they actually are) but it works great on the PR to wasmcon-workshop.

Will everything survive another rebase? Tune in to the next commit to find out.

jordan-rash and others added 3 commits October 5, 2023 10:55
Signed-off-by: Jordan Rash <15827604+jordan-rash@users.noreply.github.com>
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@connorsmith256
Copy link
Contributor

Thanks @vados-cosmonic, I introduced another merge conflict with a different PR

crates/wash-lib/src/parser/mod.rs Outdated Show resolved Hide resolved
crates/wash-lib/tests/parser/main.rs Show resolved Hide resolved
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
thomastaylor312
thomastaylor312 previously approved these changes Oct 5, 2023
Signed-off-by: Connor Smith <connor.smith.256@gmail.com>
@connorsmith256 connorsmith256 merged commit a7df4cb into main Oct 5, 2023
@connorsmith256 connorsmith256 deleted the tg_wasi_respect branch October 5, 2023 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make Tinygo Target Configurable
6 participants