go workspaces #11450

tac0turtle · 2022-03-24T18:57:38Z

Summary

create a go workspace for the cosmos-sdk in order to better prepare the repo to house more go mods and be able to run all tests at once https://go.dev/doc/tutorial/workspaces

faddat · 2022-03-24T20:14:39Z

ok, happy to do so!

would everyone be okay if the version of Go specified is 1.18 for all of our modules?

I find that using the latest helps with standardization.

alexanderbez · 2022-03-24T20:28:06Z

@faddat, yes, absolutely. No reason not to IMO

faddat · 2022-03-24T22:47:46Z

So, this looks straightforward at first, however, there is no gogoproto/protobuf v1.3.3 and I guess that go work sync reads replace statements differently:

go work sync
go: github.com/gogo/protobuf@v1.3.3: reading github.com/gogo/protobuf/go.mod at revision v1.3.3: unknown revision v1.3.3

so then I tried adding a replace to go.work

go 1.18

use (
	./api
	./container
	./cosmovisor
	./db
	./errors
	./orm
	./store/tools/ics23
)

replace github.com/gogo/protobuf v1.3.3 => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

but nonetheless I hit the same error as above. I'm pushing my work now but I think the solution could lie upstream of cosmovisor. I updated all dependencies in cosmos-sdk and the various mod files to reflect v1.3.2 (which does exist, and is then replaced by github.com/regen-network/protobuf v1.3.3-alpha.regen.1) but cosmovisor is very insistent on using 1.3.3 even if I change the go.mod file.

update:

The issue is cosmos-sdk itself, which is imported by cosmovisor. After changing the version of

github.com/gogo/protobuf v1.3.3

to

github.com/gogo/protobuf v1.3.2

it updates and I cannot do like:

module github.com/cosmos/cosmos-sdk/cosmovisor

go 1.18

require (
	github.com/cosmos/cosmos-sdk 
	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
	github.com/hashicorp/go-getter v1.5.11
	github.com/otiai10/copy v1.7.0
	github.com/rs/zerolog v1.26.1
	github.com/stretchr/testify v1.7.1
	google.golang.org/api v0.63.0 // indirect
	google.golang.org/genproto v0.0.0-20220222213610-43724f9ea8cf // indirect
	gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
)

require (
	cloud.google.com/go v0.99.0 // indirect
	cloud.google.com/go/storage v1.14.0 // indirect
	filippo.io/edwards25519 v1.0.0-beta.2 // indirect
	github.com/99designs/keyring v1.1.6 // indirect
	github.com/armon/go-metrics v0.3.10 // indirect
	github.com/aws/aws-sdk-go v1.40.45 // indirect
	github.com/beorn7/perks v1.0.1 // indirect
	github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d // indirect
	github.com/bgentry/speakeasy v0.1.0 // indirect
	github.com/btcsuite/btcd v0.22.0-beta // indirect
	github.com/cespare/xxhash v1.1.0 // indirect
	github.com/cespare/xxhash/v2 v2.1.2 // indirect
	github.com/confio/ics23/go v0.7.0 // indirect
	github.com/cosmos/btcutil v1.0.4 // indirect
	github.com/cosmos/cosmos-proto v1.0.0-alpha7 // indirect
	github.com/cosmos/cosmos-sdk/errors v1.0.0-beta.2 // indirect
	github.com/cosmos/go-bip39 v1.0.0 // indirect
	github.com/cosmos/gorocksdb v1.2.0 // indirect
	github.com/cosmos/iavl v0.17.3 // indirect
	github.com/cosmos/ledger-cosmos-go v0.11.1 // indirect
	github.com/cosmos/ledger-go v0.9.2 // indirect
	github.com/danieljoos/wincred v1.0.2 // indirect
	github.com/davecgh/go-spew v1.1.1 // indirect
	github.com/dgraph-io/badger/v2 v2.2007.4 // indirect
	github.com/dgraph-io/ristretto v0.1.0 // indirect
	github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13 // indirect
	github.com/dustin/go-humanize v1.0.0 // indirect
	github.com/dvsekhvalnov/jose2go v0.0.0-20200901110807-248326c1351b // indirect
	github.com/fsnotify/fsnotify v1.5.1 // indirect
	github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect
	github.com/gogo/protobuf v1.3.3 // indirect
	github.com/golang/glog v1.0.0 // indirect
	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
	github.com/golang/protobuf v1.5.2 // indirect
	github.com/golang/snappy v0.0.4 // indirect
	github.com/google/btree v1.0.1 // indirect
	github.com/google/gofuzz v1.1.1-0.20200604201612-c04b05f3adfa // indirect
	github.com/google/uuid v1.3.0 // indirect
	github.com/googleapis/gax-go/v2 v2.1.1 // indirect
	github.com/gorilla/mux v1.8.0 // indirect
	github.com/gorilla/websocket v1.5.0 // indirect
	github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect
	github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
	github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect
	github.com/hashicorp/go-immutable-radix v1.3.1 // indirect
	github.com/hashicorp/go-safetemp v1.0.0 // indirect
	github.com/hashicorp/go-version v1.2.1 // indirect
	github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d // indirect
	github.com/hashicorp/hcl v1.0.0 // indirect
	github.com/hdevalence/ed25519consensus v0.0.0-20210204194344-59a8610d2b87 // indirect
	github.com/inconshreveable/mousetrap v1.0.0 // indirect
	github.com/jmespath/go-jmespath v0.4.0 // indirect
	github.com/jmhodges/levigo v1.0.0 // indirect
	github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d // indirect
	github.com/klauspost/compress v1.13.6 // indirect
	github.com/magiconair/properties v1.8.6 // indirect
	github.com/mattn/go-isatty v0.0.14 // indirect
	github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
	github.com/mitchellh/go-homedir v1.1.0 // indirect
	github.com/mitchellh/go-testing-interface v1.0.0 // indirect
	github.com/mitchellh/mapstructure v1.4.3 // indirect
	github.com/mtibben/percent v0.2.1 // indirect
	github.com/oasisprotocol/curve25519-voi v0.0.0-20210609091139-0a56a4bca00b // indirect
	github.com/pelletier/go-toml v1.9.4 // indirect
	github.com/petermattis/goid v0.0.0-20180202154549-b0b1615b78e5 // indirect
	github.com/pkg/errors v0.9.1 // indirect
	github.com/pmezard/go-difflib v1.0.0 // indirect
	github.com/prometheus/client_golang v1.12.1 // indirect
	github.com/prometheus/client_model v0.2.0 // indirect
	github.com/prometheus/common v0.32.1 // indirect
	github.com/prometheus/procfs v0.7.3 // indirect
	github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 // indirect
	github.com/sasha-s/go-deadlock v0.2.1-0.20190427202633-1595213edefa // indirect
	github.com/spf13/afero v1.8.0 // indirect
	github.com/spf13/cast v1.4.1 // indirect
	github.com/spf13/cobra v1.3.0 // indirect
	github.com/spf13/jwalterweatherman v1.1.0 // indirect
	github.com/spf13/pflag v1.0.5 // indirect
	github.com/spf13/viper v1.10.1 // indirect
	github.com/subosito/gotenv v1.2.0 // indirect
	github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 // indirect
	github.com/tendermint/btcd v0.1.1 // indirect
	github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 // indirect
	github.com/tendermint/go-amino v0.16.0 // indirect
	github.com/tendermint/tendermint v0.35.2 // indirect
	github.com/tendermint/tm-db v0.6.7 // indirect
	github.com/ulikunitz/xz v0.5.8 // indirect
	github.com/zondax/hid v0.9.1-0.20220302062450-5552068d2266 // indirect
	go.etcd.io/bbolt v1.3.6 // indirect
	go.opencensus.io v0.23.0 // indirect
	golang.org/x/crypto v0.0.0-20220112180741-5e0467b6c7ce // indirect
	golang.org/x/net v0.0.0-20211208012354-db4efeb81f4b // indirect
	golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 // indirect
	golang.org/x/sys v0.0.0-20220114195835-da31bd327af9 // indirect
	golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
	golang.org/x/text v0.3.7 // indirect
	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
	google.golang.org/appengine v1.6.7 // indirect
	google.golang.org/grpc v1.45.0 // indirect
	google.golang.org/protobuf v1.28.0 // indirect
	gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
	gopkg.in/ini.v1 v1.66.3 // indirect
	gopkg.in/yaml.v2 v2.4.0 // indirect
	sigs.k8s.io/yaml v1.3.0 // indirect
)

replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1
replace github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk ../.

The second replace statement is invalid

faddat · 2022-03-24T23:00:06Z

nevermind!

../ works ;)

... but we still have this issue in both the api and cosmovisor modules.

## Description This PR works towards the completion of the Go Workspaces issue #11450 It does the following: * Upgrades the Cosmos-SDK to Go v1.18 * Changes the version of gogo/protobuf to v1.3.2, which exists upstream, unlike v1.3.3 everywhere possible. The use of the 1.3.3 version number and lack of an upstream version is the blocker for Go Workspaces. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

faddat · 2022-07-26T10:21:26Z

Closed by #12675

The reason for the new PR is that the old one contained a bunch of compatibility code that tried to remove all references to gogo/protobufs v1.3.3 which we've gotten merged in #12645, so #12675 is basically just a simplification that touches further files.

@julienrbrt mentioned that he wasn't sure if we wanted go workspaces at all-- and in the time it took me to get the concept, I wondered about that too. I am relatively sure that we do-- but not 100%.

We can think of go.work.sum as capturing the global state of this repo.

julienrbrt · 2022-07-26T19:45:00Z

Implemented by #12675.

faddat mentioned this issue Mar 24, 2022

feat: Go Workspace #11453

Closed

19 tasks

faddat mentioned this issue Apr 19, 2022

chore: Upgrade the Cosmos-SDK to Go 1.18 #11663

Merged

19 tasks

faddat mentioned this issue Jul 26, 2022

feat: go workspaces #12675

Merged

19 tasks

julienrbrt closed this as completed Jul 26, 2022

faddat mentioned this issue Aug 1, 2022

gogo/protobuf to 1.3.2, which exists, enabling go workspaces downstream cosmos/ibc-go#1844

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go workspaces #11450

go workspaces #11450

tac0turtle commented Mar 24, 2022 •

edited

Loading

faddat commented Mar 24, 2022 •

edited

Loading

alexanderbez commented Mar 24, 2022

faddat commented Mar 24, 2022 •

edited

Loading

faddat commented Mar 24, 2022 •

edited

Loading

faddat commented Jul 26, 2022

julienrbrt commented Jul 26, 2022

go workspaces #11450

go workspaces #11450

Comments

tac0turtle commented Mar 24, 2022 • edited Loading

Summary

faddat commented Mar 24, 2022 • edited Loading

alexanderbez commented Mar 24, 2022

faddat commented Mar 24, 2022 • edited Loading

faddat commented Mar 24, 2022 • edited Loading

faddat commented Jul 26, 2022

julienrbrt commented Jul 26, 2022

tac0turtle commented Mar 24, 2022 •

edited

Loading

faddat commented Mar 24, 2022 •

edited

Loading

faddat commented Mar 24, 2022 •

edited

Loading

faddat commented Mar 24, 2022 •

edited

Loading